From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB53EC43381 for ; Mon, 1 Apr 2019 18:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95EB22084B for ; Mon, 1 Apr 2019 18:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731084AbfDASDA (ORCPT ); Mon, 1 Apr 2019 14:03:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33104 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730731AbfDAROU (ORCPT ); Mon, 1 Apr 2019 13:14:20 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C30F014B8AF76; Mon, 1 Apr 2019 10:14:19 -0700 (PDT) Date: Mon, 01 Apr 2019 10:14:19 -0700 (PDT) Message-Id: <20190401.101419.1397780796470309064.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: hkallweit1@gmail.com, nic_swsd@realtek.com, netdev@vger.kernel.org, brouer@redhat.com, ecree@solarflare.com Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching From: David Miller In-Reply-To: <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com> References: <20190331.111114.1510038068515936853.davem@davemloft.net> <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 10:14:20 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Mon, 1 Apr 2019 02:17:12 -0700 > This means no GRO at all I do not think that is true as the SKB list layer does queue up to GRO.