From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Vxcv=SD=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BBC70C43381
	for <netdev@archiver.kernel.org>; Mon,  1 Apr 2019 17:41:24 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 93AA920830
	for <netdev@archiver.kernel.org>; Mon,  1 Apr 2019 17:41:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388281AbfDARlX (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 1 Apr 2019 13:41:23 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:33772 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730448AbfDARlV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 1 Apr 2019 13:41:21 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id B3C7F14B8D48D;
        Mon,  1 Apr 2019 10:41:20 -0700 (PDT)
Date:   Mon, 01 Apr 2019 10:41:20 -0700 (PDT)
Message-Id: <20190401.104120.332857372325942809.davem@davemloft.net>
To:     brouer@redhat.com
Cc:     eric.dumazet@gmail.com, hkallweit1@gmail.com, nic_swsd@realtek.com,
        netdev@vger.kernel.org, ecree@solarflare.com
Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190401145326.0196c746@carbon>
References: <20190331.111114.1510038068515936853.davem@davemloft.net>
        <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com>
        <20190401145326.0196c746@carbon>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 10:41:21 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Mon, 1 Apr 2019 14:53:26 +0200

> On Mon, 1 Apr 2019 02:17:12 -0700
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> 
>> On 03/31/2019 11:11 AM, David Miller wrote:
>> > From: Heiner Kallweit <hkallweit1@gmail.com>
>> > Date: Sun, 31 Mar 2019 15:18:48 +0200
>> >   
>> >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit
>> >> from batched skb processing.
>> >>
>> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>  
>> > 
>> > Applied.
>> >   
>> 
>> This means no GRO at all, and reduced performance in many useful
>> cases.
> 
> As Eric says, this in-effect disables GRO for this driver.

Really?  __netif_receive_skb_list_core() does GRO.