From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5FCC43381 for ; Mon, 1 Apr 2019 21:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3901120856 for ; Mon, 1 Apr 2019 21:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbfDAVud (ORCPT ); Mon, 1 Apr 2019 17:50:33 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38616 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbfDAVud (ORCPT ); Mon, 1 Apr 2019 17:50:33 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C7C9A123A52C6; Mon, 1 Apr 2019 14:50:32 -0700 (PDT) Date: Mon, 01 Apr 2019 14:50:29 -0700 (PDT) Message-Id: <20190401.145029.173182112322536212.davem@davemloft.net> To: pabeni@redhat.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, john.fastabend@gmail.com Subject: Re: [PATCH net 0/2] net: sched: fix stats accounting for child NOLOCK qdiscs From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 14:50:33 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Paolo Abeni Date: Thu, 28 Mar 2019 16:53:11 +0100 > Currently, stats accounting for NOLOCK qdisc enslaved to classful (lock) > qdiscs is buggy. Per CPU values are ignored in most places, as a result, > stats dump in the above scenario always report 0 length backlog and parent > backlog len is not updated correctly on NOLOCK qdisc removal. > > The first patch address stats dumping, and the second one child qdisc removal. > I'm targeting the net tree as this is a bugfix, but it could be moved to > net-next due to the relatively large diffstat. Series applied, thanks Paolo.