From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: netdev@vger.kernel.org, ak@linux.intel.com
Subject: Re: [PATCH] ipv4 ping: Fix __init* attributes
Date: Mon, 01 Apr 2019 18:00:06 -0700 (PDT) [thread overview]
Message-ID: <20190401.180006.1452941870052618794.davem@davemloft.net> (raw)
In-Reply-To: <20190330004600.29277-1-andi@firstfloor.org>
From: Andi Kleen <andi@firstfloor.org>
Date: Fri, 29 Mar 2019 17:46:00 -0700
> From: Andi Kleen <ak@linux.intel.com>
>
> ping_v4_net_ops references init functions, so needs to be __initdata.
> ping_proc_exit is then referenced from __initdata, so also needs
> to be __init.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
How can you spin up new network namespaces properly if you mark
this thing __init?
What __init functions does it even reference? It just creates and
destroys procfs files.
This patch doesn't seem correct, I'm not applying it.
prev parent reply other threads:[~2019-04-02 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 0:46 [PATCH] ipv4 ping: Fix __init* attributes Andi Kleen
2019-04-02 1:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401.180006.1452941870052618794.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).