From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 683CDC43381 for ; Tue, 2 Apr 2019 01:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 255FC20657 for ; Tue, 2 Apr 2019 01:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728683AbfDBBAL (ORCPT ); Mon, 1 Apr 2019 21:00:11 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40770 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbfDBBAL (ORCPT ); Mon, 1 Apr 2019 21:00:11 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C9D2D133E975B; Mon, 1 Apr 2019 18:00:10 -0700 (PDT) Date: Mon, 01 Apr 2019 18:00:06 -0700 (PDT) Message-Id: <20190401.180006.1452941870052618794.davem@davemloft.net> To: andi@firstfloor.org Cc: netdev@vger.kernel.org, ak@linux.intel.com Subject: Re: [PATCH] ipv4 ping: Fix __init* attributes From: David Miller In-Reply-To: <20190330004600.29277-1-andi@firstfloor.org> References: <20190330004600.29277-1-andi@firstfloor.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 18:00:11 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andi Kleen Date: Fri, 29 Mar 2019 17:46:00 -0700 > From: Andi Kleen > > ping_v4_net_ops references init functions, so needs to be __initdata. > ping_proc_exit is then referenced from __initdata, so also needs > to be __init. > > Signed-off-by: Andi Kleen How can you spin up new network namespaces properly if you mark this thing __init? What __init functions does it even reference? It just creates and destroys procfs files. This patch doesn't seem correct, I'm not applying it.