From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=57Sx=SE=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0ACC43381
	for <netdev@archiver.kernel.org>; Tue,  2 Apr 2019 01:07:15 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 60D3420833
	for <netdev@archiver.kernel.org>; Tue,  2 Apr 2019 01:07:15 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726841AbfDBBHO (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 1 Apr 2019 21:07:14 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:40984 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726072AbfDBBHO (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 1 Apr 2019 21:07:14 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 99363133E975B;
        Mon,  1 Apr 2019 18:07:13 -0700 (PDT)
Date:   Mon, 01 Apr 2019 18:07:13 -0700 (PDT)
Message-Id: <20190401.180713.1437137170304848375.davem@davemloft.net>
To:     hkallweit1@gmail.com
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status
From:   David Miller <davem@davemloft.net>
In-Reply-To: <36da82de-6dad-939e-7604-d3c0b93f54c8@gmail.com>
References: <36da82de-6dad-939e-7604-d3c0b93f54c8@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 18:07:13 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sat, 30 Mar 2019 10:22:45 +0100

> This patch improves few aspects of genphy_read_status():
> 
> - Don't initialize lpagb, it's not needed.
> 
> - Move initializing phydev->speed et al before the if clause.
> 
> - In auto-neg case, skip populating lp_advertising if we
>   don't have a link. This avoids quite some unnecessary
>   MDIO reads in case of phylib polling mode.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

I decided that I'm not going to push back on this patch purely on the
issue of not touching the conditional ordering.

Applied, thanks Heiner.