From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E688C43381 for ; Mon, 1 Apr 2019 06:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5228920896 for ; Mon, 1 Apr 2019 06:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554100680; bh=hbCu0FNMmg4aR2J6CsbpTktRyIzqL2gcyzkD/IaQjmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rKr8znzhsBJQ2xBDVNsojoAKQM7iko1b8v7w+hojQbEaAtd4UfEwQCaG3SC8uOq+s DW1j8a2Z0aQvyIA05LGy8X8KTAXR9oc6ZRHnJtLUPgQW13fuy4kEmPnzmphHt4RPQX ezlLnnj3+lIXOgIbIxoQLo/5cZeJNfAazfFuja6A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731811AbfDAGh7 (ORCPT ); Mon, 1 Apr 2019 02:37:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727447AbfDAGh6 (ORCPT ); Mon, 1 Apr 2019 02:37:58 -0400 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A2B9320896; Mon, 1 Apr 2019 06:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554100678; bh=hbCu0FNMmg4aR2J6CsbpTktRyIzqL2gcyzkD/IaQjmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N5KYxt6sTR3lVjEMe8xFdL+ebT9vJ/XxTWdEVCFYDpZVZf6lFrzU3t8M5V+dP4CvC NJXRErwj7RZ/EuOguk2+v2wxKs0KQCSlsN42rh6NhlwW4bEJuRwOednL8ZNF1M4F87 WYpweNwAxxgS0xruU4yhfhe0yOGqBvvbGmHXA2JM= Date: Mon, 1 Apr 2019 09:37:55 +0300 From: Leon Romanovsky To: Steve Wise Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v2 iproute2-next 3/4] rdma: add 'link add/delete' commands Message-ID: <20190401063755.GG8348@mtr-leonro.mtl.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yRA+Bmk8aPhU85Qt" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --yRA+Bmk8aPhU85Qt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 26, 2019 at 02:18:29PM -0500, Steve Wise wrote: > Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > device to a netdev interface. > > EG: > > rdma link add rxe_eth0 type rxe netdev eth0 > rdma link delete rxe_eth0 > > Signed-off-by: Steve Wise > --- > rdma/link.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > rdma/rdma.h | 2 ++ > 2 files changed, 85 insertions(+) > > diff --git a/rdma/link.c b/rdma/link.c > index 89e81b84..982c2b16 100644 > --- a/rdma/link.c > +++ b/rdma/link.c > @@ -9,6 +9,9 @@ > static int link_help(struct rd *rd) > { > pr_out("Usage: %s link show [DEV/PORT_INDEX]\n", rd->filename); > + pr_out("Usage: %s link add NAME type TYPE netdev NETDEV\n", > + rd->filename); > + pr_out("Usage: %s link delete NAME\n", rd->filename); > return 0; > } > > @@ -336,10 +339,90 @@ static int link_show(struct rd *rd) > return rd_exec_link(rd, link_one_show, true); > } > > +static int link_add_netdev(struct rd *rd) > +{ > + rd->link_netdev = rd_argv(rd); > + rd_arg_inc(rd); > + return 0; > +} > + > +static int link_add_type(struct rd *rd) > +{ > + const struct rd_cmd cmds[] = { > + { NULL, link_help}, > + { "netdev", link_add_netdev}, > + { 0 } > + }; > + rd->link_type = rd_argv(rd); > + rd_arg_inc(rd); > + return rd_exec_cmd(rd, cmds, "parameter"); > +} > + > +static int link_add(struct rd *rd) > +{ > + const struct rd_cmd cmds[] = { > + { NULL, link_help}, > + { "type", link_add_type}, > + { 0 } > + }; > + > + uint32_t seq; > + char *name; > + int ret; > + > + if (rd_no_arg(rd)) { > + pr_err("Please provide a link name to add.\n"); > + return -EINVAL; > + } > + name = rd_argv(rd); > + rd_arg_inc(rd); > + > + ret = rd_exec_cmd(rd, cmds, "parameter"); > + if (ret) > + return ret; > + > + if (!rd->link_type) { > + pr_err("Please provide a link type name.\n"); > + return -EINVAL; > + } > + if (!rd->link_netdev) { > + pr_err("Please provide a net device name.\n"); > + return -EINVAL; > + } After a little bit more thinking, the checks above are supposed to be part of rd_exec_cmd() execution of chains. E.g if (!rd->link_type) needs to be inside link_add_type(). > + > + rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, &seq, > + (NLM_F_REQUEST | NLM_F_ACK)); > + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, name); > + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_LINK_TYPE, rd->link_type); > + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_NDEV_NAME, rd->link_netdev); > + return rd_sendrecv_msg(rd, seq); > +} > + > +static int _link_del(struct rd *rd) > +{ > + uint32_t seq; > + > + if (!rd_no_arg(rd)) { > + pr_err("Unknown parameter %s\n", rd_argv(rd)); > + return -EINVAL; > + } > + rd_prepare_msg(rd, RDMA_NLDEV_CMD_DELLINK, &seq, > + (NLM_F_REQUEST | NLM_F_ACK)); > + mnl_attr_put_u32(rd->nlh, RDMA_NLDEV_ATTR_DEV_INDEX, rd->dev_idx); > + return rd_sendrecv_msg(rd, seq); > +} > + > +static int link_del(struct rd *rd) > +{ > + return rd_exec_require_dev(rd, _link_del); > +} > + > int cmd_link(struct rd *rd) > { > const struct rd_cmd cmds[] = { > { NULL, link_show }, > + { "add", link_add }, > + { "delete", link_del }, > { "show", link_show }, > { "list", link_show }, > { "help", link_help }, > diff --git a/rdma/rdma.h b/rdma/rdma.h > index 6c7f7d15..070c8ddf 100644 > --- a/rdma/rdma.h > +++ b/rdma/rdma.h > @@ -70,6 +70,8 @@ struct rd { > bool pretty_output; > bool suppress_errors; > struct list_head filter_list; > + char *link_type; > + char *link_netdev; > }; > > struct rd_cmd { > -- > 2.20.1 > --yRA+Bmk8aPhU85Qt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcobHDAAoJEORje4g2clin7ccP/1Ahjt71JDwKnxm8DwNOzda8 ONLqq13usyAIuGV/n3sUkQpteuDk+ZpWiVn850pNGcaPCcPAAI7twPWCoPxuaEX/ xt9qd6VhfrCh7yJimZrCYTu6kGZrctOtnytNDASc3q4LFal32XNQvXb9/yvsC44b K5krb10q7wURg1EQnnIE04tr8PKepST6yTUHUJOWEUC2bqtQSnD6bJpj8rqzavAk 7zZ4Ex8Y9Tmaui7vSKmB+L1I9M4b2temoepvROqYX3DrJbjRV+tnTTPyVbptZpS4 Zyw5iw7Y0cNgXevcZlrAuP3/dtrxOh7L7C4ufc+CUMYSZcImokmPjcquRwlDSr1j Z24Qc4sh8u3X6jarRTLgMYIhGysEClGThTQF4hp6wsJGPQtw83xNbBPGiKHZkLGJ /kMLDd7EmfjGG6biygwSv78HWmDi1iO97M3OkVf8R1mLCbf7pV1PBMMHbLe0Flio OJP+p+uNd0dvdNQlLKBuQ5y6mojplC33nnWMsq8zprv/Q5FLk8gRPdnEMfjzdX3o AfbI+2Bz4qpHMwTnP6ss9VtiaHI3uACxvIpV+ynQm0jBwySaKAqIvliSnMKgwCNG EQB+orZlbWRgyhF64SZqF9LqAfIW3gXosfvl4BnXWmKVY23TjAD/i88ZKMJ0TuO3 dDESn77KzwgJJaTp3HyS =0cTe -----END PGP SIGNATURE----- --yRA+Bmk8aPhU85Qt--