From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 360AAC43381 for ; Mon, 1 Apr 2019 13:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E95782086C for ; Mon, 1 Apr 2019 13:14:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mXceQO9F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbfDANO3 (ORCPT ); Mon, 1 Apr 2019 09:14:29 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:37245 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726762AbfDANO2 (ORCPT ); Mon, 1 Apr 2019 09:14:28 -0400 Received: by mail-qk1-f195.google.com with SMTP id c1so5552460qkk.4 for ; Mon, 01 Apr 2019 06:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NQmLVGSBZJBguVKNdQw3ndEE+vGFCiliqSJv3DwyZvM=; b=mXceQO9FBwDMLHD89ym3Fw8gpWbCAaB3yeCx1I7QWrylU7SbVmlU4DlZCCzruIpRZo 3JIHFE6o6pU4mIGrZrIKQj6LxPknGVDbTDAAJ4aT3OgsTKj8U1Y+WicYJ/CL5ZAxIrXT vr8XiLUGnPe6aZ5wFssGkTHPys9R203tyL9p9XYUW018c8BwyQjxOOaHdRtNy8kBBdxa ylUrLT53P3P0EbLSIt0MCaOnKIOLVI3hRJ6ZjGgzR8okTWqZmtgWckHTmxcwFYqKdSS9 bzElVCXVyyztswPuUbEWGwATcJ4LSWC/jWV8OXGXfWEJrlF1uMoR7zHme4ivQV/673nM uYRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NQmLVGSBZJBguVKNdQw3ndEE+vGFCiliqSJv3DwyZvM=; b=a32AHgEmyRwcW2EKokHzf3dPXSdSHpREXO2vft2A9OGU0O+09OYTXom8ATdEkLzawi /5x17UKqrIFxn+ZQaaOp7Kr08zx8ksM5R1Stiap0HWtTskw9SlV1lezSGI4FvHkHgrHV C6P/D7vP+pE2fiOnJYo13PLSmqBiqp17B8uOs9oATz3S4YW2hTY0BM6Gm8Pn4hFDaGDS 2NSDcXq8khxEV/m+OL20JXlJDv74WhdtHWBWTMvv/aTmp0NS3q00i3+jsk364mRDc/bR NESxE9OfG2kgGVN/J5ii2p6kletbIGULl7y1J/sv3bNNQ54tT2sQTVcip16p1u9XQmrf E13w== X-Gm-Message-State: APjAAAX0kIFCa9f7yVnNRA4+PMzmUMk0lMBZi14PYw4I5UcaXTO/+MCO 9JHdmGAn+2hT0OAmdbgFJDM= X-Google-Smtp-Source: APXvYqxa40te62PVKWZYqTUc5ZdHp9vQbJypCGL7T3uZ26fe02mvxOtUsXGM9Z6uLqwOnTzCLGwRlQ== X-Received: by 2002:a37:dd8:: with SMTP id 207mr41836656qkn.278.1554124467599; Mon, 01 Apr 2019 06:14:27 -0700 (PDT) Received: from localhost.localdomain ([2001:1284:f016:2044:bfe6:d5b1:318e:446e]) by smtp.gmail.com with ESMTPSA id x2sm4991142qkj.59.2019.04.01.06.14.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 06:14:26 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 31B61180C25; Mon, 1 Apr 2019 10:14:24 -0300 (-03) Date: Mon, 1 Apr 2019 10:14:24 -0300 From: Marcelo Ricardo Leitner To: Kevin 'ldir' Darbyshire-Bryant Cc: "jhs@mojatatu.com" , "jiri@resnulli.us" , "netdev@vger.kernel.org" , "xiyou.wangcong@gmail.com" , Paul Blakey , Oz Shlomo Subject: Re: [RFC net-next 0/1] net: sched: Introduce conntrack action Message-ID: <20190401131423.GB13514@localhost.localdomain> References: <20190329204438.68777-1-ldir@darbyshire-bryant.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190329204438.68777-1-ldir@darbyshire-bryant.me.uk> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Fri, Mar 29, 2019 at 08:45:06PM +0000, Kevin 'ldir' Darbyshire-Bryant wrote: > Hi Cong, > > OK, so I've renamed conndscp to conntrack and hopefully this are > flexible enough for future conntrack->skb operations to be added in the > future. How does this one fly? This work sort of clashes with the work that Paul Blakey and I are doing to integrate conntrack with tc and vice-versa. Considering that in this patch the action is not RCU-ified, that it is using a struct as netlink parameter and it is dealing only with the dscp info, seems it's easier if we/you extend our code to support this feature as well. How does that sound to you? The RFC I had posted is VERY outdated (message-id cover.1548285996.git.mleitner@redhat.com), please don't use it as reference. Not sure if Paul can post a refreshed RFC already. Thanks, Marcelo