From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6657C43381 for ; Mon, 1 Apr 2019 12:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A315120883 for ; Mon, 1 Apr 2019 12:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbfDAMxe (ORCPT ); Mon, 1 Apr 2019 08:53:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfDAMxe (ORCPT ); Mon, 1 Apr 2019 08:53:34 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E394C12B38; Mon, 1 Apr 2019 12:53:33 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DCE25D9C5; Mon, 1 Apr 2019 12:53:28 +0000 (UTC) Date: Mon, 1 Apr 2019 14:53:26 +0200 From: Jesper Dangaard Brouer To: Eric Dumazet Cc: David Miller , hkallweit1@gmail.com, nic_swsd@realtek.com, netdev@vger.kernel.org, ecree@solarflare.com, brouer@redhat.com Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching Message-ID: <20190401145326.0196c746@carbon> In-Reply-To: <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com> References: <20190331.111114.1510038068515936853.davem@davemloft.net> <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 01 Apr 2019 12:53:34 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 1 Apr 2019 02:17:12 -0700 Eric Dumazet wrote: > On 03/31/2019 11:11 AM, David Miller wrote: > > From: Heiner Kallweit > > Date: Sun, 31 Mar 2019 15:18:48 +0200 > > > >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit > >> from batched skb processing. > >> > >> Signed-off-by: Heiner Kallweit > > > > Applied. > > > > This means no GRO at all, and reduced performance in many useful > cases. As Eric says, this in-effect disables GRO for this driver. This will very likely give a slowdown for local TCP delivery (while it might helps for UDP and forwarding). That is why I was saying we need a GRO version of this... (which need to be combined with bulk SKB alloc, to compete with GRO fast-recycle of same SKB). -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer