From: Sabrina Dubroca <sd@queasysnail.net>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] macsec: add noinline tag to avoid a frame size warning
Date: Mon, 1 Apr 2019 22:51:43 +0200 [thread overview]
Message-ID: <20190401205143.GA19447@bistromath.localdomain> (raw)
In-Reply-To: <20190401093750.1637-1-fw@strlen.de>
2019-04-01, 11:37:50 +0200, Florian Westphal wrote:
> seen with debug config:
> drivers/net/macsec.c: In function 'dump_secy':
> drivers/net/macsec.c:2597: warning: the frame size of 2216 bytes is larger
> than 2048 bytes [-Wframe-larger-than=]
>
> just mark it with noinline_for_stack, this is netlink dump code.
>
> Cc: Sabrina Dubroca <sd@queasysnail.net>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> drivers/net/macsec.c | 22 ++++++++++++----------
> 1 file changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
> index 947c40f112d1..dbea9452b19a 100644
> --- a/drivers/net/macsec.c
> +++ b/drivers/net/macsec.c
> @@ -2175,8 +2175,9 @@ static int copy_tx_sa_stats(struct sk_buff *skb,
> return 0;
> }
>
> -static int copy_rx_sa_stats(struct sk_buff *skb,
> - struct macsec_rx_sa_stats __percpu *pstats)
> +static int noinline_for_stack
Could you swap int/noinline_for_stack to be consistent with the rest?
static noinline_for_stack int
Other than that, lgtm, thanks.
--
Sabrina
prev parent reply other threads:[~2019-04-01 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 9:37 [PATCH net-next] macsec: add noinline tag to avoid a frame size warning Florian Westphal
2019-04-01 20:51 ` Sabrina Dubroca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401205143.GA19447@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).