From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E911C43381 for ; Mon, 1 Apr 2019 20:51:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41EEA20857 for ; Mon, 1 Apr 2019 20:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727056AbfDAUvr (ORCPT ); Mon, 1 Apr 2019 16:51:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38604 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbfDAUvq (ORCPT ); Mon, 1 Apr 2019 16:51:46 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F16231688FA; Mon, 1 Apr 2019 20:51:46 +0000 (UTC) Received: from bistromath.localdomain (unknown [10.40.205.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89F4E5D6A6; Mon, 1 Apr 2019 20:51:45 +0000 (UTC) Date: Mon, 1 Apr 2019 22:51:43 +0200 From: Sabrina Dubroca To: Florian Westphal Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next] macsec: add noinline tag to avoid a frame size warning Message-ID: <20190401205143.GA19447@bistromath.localdomain> References: <20190401093750.1637-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190401093750.1637-1-fw@strlen.de> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 01 Apr 2019 20:51:46 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-04-01, 11:37:50 +0200, Florian Westphal wrote: > seen with debug config: > drivers/net/macsec.c: In function 'dump_secy': > drivers/net/macsec.c:2597: warning: the frame size of 2216 bytes is larger > than 2048 bytes [-Wframe-larger-than=] > > just mark it with noinline_for_stack, this is netlink dump code. > > Cc: Sabrina Dubroca > Signed-off-by: Florian Westphal > --- > drivers/net/macsec.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c > index 947c40f112d1..dbea9452b19a 100644 > --- a/drivers/net/macsec.c > +++ b/drivers/net/macsec.c > @@ -2175,8 +2175,9 @@ static int copy_tx_sa_stats(struct sk_buff *skb, > return 0; > } > > -static int copy_rx_sa_stats(struct sk_buff *skb, > - struct macsec_rx_sa_stats __percpu *pstats) > +static int noinline_for_stack Could you swap int/noinline_for_stack to be consistent with the rest? static noinline_for_stack int Other than that, lgtm, thanks. -- Sabrina