From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Vxcv=SD=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2A3C43381
	for <netdev@archiver.kernel.org>; Mon,  1 Apr 2019 21:48:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 11B882084B
	for <netdev@archiver.kernel.org>; Mon,  1 Apr 2019 21:48:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726705AbfDAVsu (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 1 Apr 2019 17:48:50 -0400
Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:56938 "EHLO
        Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1725889AbfDAVst (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 1 Apr 2019 17:48:49 -0400
Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89)
        (envelope-from <fw@strlen.de>)
        id 1hB4nP-0006gu-5l; Mon, 01 Apr 2019 23:48:47 +0200
Date:   Mon, 1 Apr 2019 23:48:47 +0200
From:   Florian Westphal <fw@strlen.de>
To:     Captain Wiggum <captwiggum@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Westphal <fw@strlen.de>,
        Eric Dumazet <edumazet@google.com>,
        Peter Oskolkov <posk@google.com>, netdev@vger.kernel.org
Subject: Re: Please merge IPv6 fix for drop fragment smaller than MTU
Message-ID: <20190401214847.7aa5l4wpiyita75x@breakpoint.cc>
References: <CAB=W+ok36bXgj7Dmkid1bM8h_Hq-D=4mnfFrreQBxGy=2_k1Rw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAB=W+ok36bXgj7Dmkid1bM8h_Hq-D=4mnfFrreQBxGy=2_k1Rw@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

Captain Wiggum <captwiggum@gmail.com> wrote:
> An error was introduced in 4.9.134 (and the other LTS branches also).
> This causes 18 test cases from the TAHI IPv6 test suite to fail.
> I added you to the mail thread about this subject a month back.
> It has been fixed in upstream for some time now, but not in the LTS branches.
> Please merge this undo-patch into the LTS branches.

This is only safe after backporting Peters work to convert
IPv6 to use RB Trees for the reassembly queues,
otherwise a revert adds back the DoS vector.

commit d4289fcc9b16b89619ee1c54f829e05e56de8b9a
net: IP6 defrag: use rbtrees for IPv6 defrag

commit 997dd96471641e147cb2c33ad54284000d0f5e35
net: IP6 defrag: use rbtrees in nf_conntrack_reasm.c