From: David Miller <davem@davemloft.net>
To: sheena.mira-ato@alliedtelesis.co.nz
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] ip6_tunnel: Match to ARPHRD_TUNNEL6 for dev type
Date: Tue, 02 Apr 2019 13:20:06 -0700 (PDT) [thread overview]
Message-ID: <20190402.132006.1252934055846128056.davem@davemloft.net> (raw)
In-Reply-To: <20190401000442.30520-1-sheena.mira-ato@alliedtelesis.co.nz>
From: Sheena Mira-ato <sheena.mira-ato@alliedtelesis.co.nz>
Date: Mon, 1 Apr 2019 13:04:42 +1300
> The device type for ip6 tunnels is set to
> ARPHRD_TUNNEL6. However, the ip4ip6_err function
> is expecting the device type of the tunnel to be
> ARPHRD_TUNNEL. Since the device types do not
> match, the function exits and the ICMP error
> packet is not sent to the originating host. Note
> that the device type for IPv4 tunnels is set to
> ARPHRD_TUNNEL.
>
> Fix is to expect a tunnel device type of
> ARPHRD_TUNNEL6 instead. Now the tunnel device
> type matches and the ICMP error packet is sent
> to the originating host.
>
> Signed-off-by: Sheena Mira-ato <sheena.mira-ato@alliedtelesis.co.nz>
Applied and queued up for -stable.
next prev parent reply other threads:[~2019-04-02 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 0:04 [PATCH] ip6_tunnel: Match to ARPHRD_TUNNEL6 for dev type Sheena Mira-ato
2019-04-02 20:20 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-09 20:36 Sheena Mira-ato
2019-04-11 21:15 ` David Miller
2019-04-11 22:29 ` Sheena Mira-ato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402.132006.1252934055846128056.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=sheena.mira-ato@alliedtelesis.co.nz \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).