From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1716DC4360F for ; Tue, 2 Apr 2019 20:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF2442070D for ; Tue, 2 Apr 2019 20:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725965AbfDBUUH (ORCPT ); Tue, 2 Apr 2019 16:20:07 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:32832 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbfDBUUH (ORCPT ); Tue, 2 Apr 2019 16:20:07 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B9DA2133FCD26; Tue, 2 Apr 2019 13:20:06 -0700 (PDT) Date: Tue, 02 Apr 2019 13:20:06 -0700 (PDT) Message-Id: <20190402.132006.1252934055846128056.davem@davemloft.net> To: sheena.mira-ato@alliedtelesis.co.nz Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Subject: Re: [PATCH] ip6_tunnel: Match to ARPHRD_TUNNEL6 for dev type From: David Miller In-Reply-To: <20190401000442.30520-1-sheena.mira-ato@alliedtelesis.co.nz> References: <20190401000442.30520-1-sheena.mira-ato@alliedtelesis.co.nz> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 02 Apr 2019 13:20:06 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sheena Mira-ato Date: Mon, 1 Apr 2019 13:04:42 +1300 > The device type for ip6 tunnels is set to > ARPHRD_TUNNEL6. However, the ip4ip6_err function > is expecting the device type of the tunnel to be > ARPHRD_TUNNEL. Since the device types do not > match, the function exits and the ICMP error > packet is not sent to the originating host. Note > that the device type for IPv4 tunnels is set to > ARPHRD_TUNNEL. > > Fix is to expect a tunnel device type of > ARPHRD_TUNNEL6 instead. Now the tunnel device > type matches and the ICMP error packet is sent > to the originating host. > > Signed-off-by: Sheena Mira-ato Applied and queued up for -stable.