From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: use c45 standard to detect link partner autoneg capability
Date: Tue, 2 Apr 2019 15:56:37 +0200 [thread overview]
Message-ID: <20190402135637.GC18443@lunn.ch> (raw)
In-Reply-To: <0eba5bda-62c1-711e-12b5-1d71593ffad8@gmail.com>
On Sun, Mar 31, 2019 at 07:52:51PM +0200, Heiner Kallweit wrote:
> Currently mii_lpa_mod_linkmode_lpa_t() checks bit LPA_LPACK to detect
> whether link partner supports autoneg. This doesn't work correctly at
> least on Aquantia AQCS109 when it negotiates 1000Base-T2 mode.
> The "link partner is autoneg-capable" bit as defined by clause 45 is
> set however. Better let's switch in general to use the clause 45
> standard for link partner autoneg detection.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-04-02 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 17:51 [PATCH net-next 0/2] net: phy: improve genphy_c45_read_lpa Heiner Kallweit
2019-03-31 17:52 ` [PATCH net-next 1/2] net: phy: use c45 standard to detect link partner autoneg capability Heiner Kallweit
2019-04-02 13:56 ` Andrew Lunn [this message]
2019-03-31 17:54 ` [PATCH net-next 2/2] net: phy: deal properly with autoneg incomplete in genphy_c45_read_lpa Heiner Kallweit
2019-04-02 13:56 ` Andrew Lunn
2019-04-02 20:16 ` [PATCH net-next 0/2] net: phy: improve genphy_c45_read_lpa David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402135637.GC18443@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).