From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: fix autoneg mismatch case in genphy_read_status
Date: Tue, 2 Apr 2019 22:40:03 +0200 [thread overview]
Message-ID: <20190402204003.GC22349@lunn.ch> (raw)
In-Reply-To: <ad288d85-ea57-82bc-5711-1a0fbaad2aa8@gmail.com>
On Tue, Apr 02, 2019 at 08:43:30PM +0200, Heiner Kallweit wrote:
> The original patch didn't consider the case that autoneg process
> finishes successfully but both link partners have no mode in common.
> In this case there's no link, nevertheless we may be interested in
> what the link partner advertised.
>
> Like phydev->link we set phydev->autoneg_complete in
> genphy_update_link() and use the stored value in genphy_read_status().
> This way we don't have to read register BMSR again.
>
> Fixes: b6163f194c69 ("net: phy: improve genphy_read_status")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-04-02 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 18:43 [PATCH net-next] net: phy: fix autoneg mismatch case in genphy_read_status Heiner Kallweit
2019-04-02 20:40 ` Andrew Lunn [this message]
2019-04-04 4:48 ` David Miller
2019-04-05 16:16 ` Simon Horman
2019-04-05 17:40 ` Heiner Kallweit
2019-04-06 17:57 ` Heiner Kallweit
2019-04-08 7:46 ` Simon Horman
2019-04-07 15:09 ` Heiner Kallweit
2019-04-08 7:47 ` Simon Horman
2019-04-08 17:29 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402204003.GC22349@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).