From: David Miller <davem@davemloft.net>
To: hujunwei4@huawei.com
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mingfangsen@huawei.com, liuzhiqiang26@huawei.com
Subject: Re: [PATCH v4 net] ipv6: Fix dangling pointer when ipv6 fragment
Date: Wed, 03 Apr 2019 21:43:14 -0700 (PDT) [thread overview]
Message-ID: <20190403.214314.643123707100892779.davem@davemloft.net> (raw)
In-Reply-To: <aaccfa09-8acf-e247-ab71-3d6ec3803f55@huawei.com>
From: hujunwei <hujunwei4@huawei.com>
Date: Tue, 2 Apr 2019 19:38:04 +0800
> From: Junwei Hu <hujunwei4@huawei.com>
>
> At the beginning of ip6_fragment func, the prevhdr pointer is
> obtained in the ip6_find_1stfragopt func.
> However, all the pointers pointing into skb header may change
> when calling skb_checksum_help func with
> skb->ip_summed = CHECKSUM_PARTIAL condition.
> The prevhdr pointe will be dangling if it is not reloaded after
> calling __skb_linearize func in skb_checksum_help func.
>
> Here, I add a variable, nexthdr_offset, to evaluate the offset,
> which does not changes even after calling __skb_linearize func.
>
> Fixes: 405c92f7a541 ("ipv6: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment")
> Signed-off-by: Junwei Hu <hujunwei4@huawei.com>
> Reported-by: Wenhao Zhang <zhangwenhao8@huawei.com>
> Reported-by: syzbot+e8ce541d095e486074fc@syzkaller.appspotmail.com
> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> Acked-by: Martin KaFai Lau <kafai@fb.com>
> ---
> V3->V4:
> - fix build warning
Applied and queued up for -stable.
prev parent reply other threads:[~2019-04-04 4:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 11:38 [PATCH v4 net] ipv6: Fix dangling pointer when ipv6 fragment hujunwei
2019-04-04 4:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403.214314.643123707100892779.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hujunwei4@huawei.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=mingfangsen@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).