From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD49BC4360F for ; Wed, 3 Apr 2019 08:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C3A52084B for ; Wed, 3 Apr 2019 08:31:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728635AbfDCIbk (ORCPT ); Wed, 3 Apr 2019 04:31:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34734 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfDCIbk (ORCPT ); Wed, 3 Apr 2019 04:31:40 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED3D8368E7; Wed, 3 Apr 2019 08:31:39 +0000 (UTC) Received: from bistromath.localdomain (unknown [10.40.205.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2E3D60145; Wed, 3 Apr 2019 08:31:37 +0000 (UTC) Date: Wed, 3 Apr 2019 10:31:35 +0200 From: Sabrina Dubroca To: Florian Westphal Cc: netdev@vger.kernel.org Subject: Re: [PATCH v2 ipsec-next 00/11] xfrm: remove xfrm_mode indirections Message-ID: <20190403083135.GA12873@bistromath.localdomain> References: <20190329201632.11149-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190329201632.11149-1-fw@strlen.de> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 03 Apr 2019 08:31:40 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-03-29, 21:16:21 +0100, Florian Westphal wrote: > This series removes all function pointers from the xfrm_mode struct. > They are either replaced by direct calls or a static helper. > > This reduces code size: even merging all xfrm{4,6}_,mode* modules > into the core reduces total size, as the infrastructure to maintain > dynamic (un)register can be removed. > > There are more opportunities for indirection avoidance, e.g. in > xfrm_type. I plan to follow up once/if this series is accepted. > > Tested with xfrm tunnel mode via netns with esp/aead. > > I'd like thank Benedict Wong for running Android unit tests > and taking the time to bisect a tunnel mode breakage added by > v1 of this patch set. > > I've addressed the comments/feedback from Sabrina and Eyal. > The kbuild robot reported build breakage in patch #8 is fixed > as well. > > I've not addressed the sparse warning reported by the > kbuild robot -- those warnings are in code not touched > by this patch set. > > Florian Westphal (11): > xfrm: place af number into xfrm_mode struct > xfrm: prefer family stored in xfrm_mode struct > xfrm: remove input indirection from xfrm_mode > xfrm: remove output indirection from xfrm_mode > xfrm: remove xmit indirection from xfrm_mode > xfrm: remove gso_segment indirection from xfrm_mode > xfrm: remove input2 indirection from xfrm_mode > xfrm: remove output2 indirection from xfrm_mode > xfrm: remove afinfo pointer from xfrm_mode > xfrm: make xfrm modes builtin > xfrm: store xfrm_mode directly, not its address Series: Reviewed-by: Sabrina Dubroca -- Sabrina