From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: realtek: remove setting callback get_features and use phylib fallback
Date: Wed, 3 Apr 2019 22:55:21 +0200 [thread overview]
Message-ID: <20190403205521.GG4592@lunn.ch> (raw)
In-Reply-To: <9881fca7-1531-ed66-e3d0-be0a9372f829@gmail.com>
On Wed, Apr 03, 2019 at 08:20:09PM +0200, Heiner Kallweit wrote:
> Now that phylib uses genphy_read_abilities() as fallback, we don't have
> to set callback get_features any longer.
Hi Heiner
I wonder how many PHY drivers we will break if we just remove
.features everywhere?
Maybe we should create patches for the Marvell driver and the Broadcom
drivers. I and Florian can test them.
Andrew
next prev parent reply other threads:[~2019-04-03 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 18:17 [PATCH net-next 0/2] net: phy: use generic PHY ability readers if callback get_features isn't set Heiner Kallweit
2019-04-03 18:19 ` [PATCH net-next 1/2] net: phy: allow a PHY driver to define neither features nor get_features Heiner Kallweit
2019-04-03 20:46 ` Andrew Lunn
2019-04-03 20:59 ` Heiner Kallweit
2019-04-03 18:20 ` [PATCH net-next 2/2] net: phy: realtek: remove setting callback get_features and use phylib fallback Heiner Kallweit
2019-04-03 20:55 ` Andrew Lunn [this message]
2019-04-03 21:06 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403205521.GG4592@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).