From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A88EBC4360F for ; Wed, 3 Apr 2019 22:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7102C2133D for ; Wed, 3 Apr 2019 22:18:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qzW9YPDh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726337AbfDCWSF (ORCPT ); Wed, 3 Apr 2019 18:18:05 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34459 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfDCWSE (ORCPT ); Wed, 3 Apr 2019 18:18:04 -0400 Received: by mail-pg1-f194.google.com with SMTP id v12so174844pgq.1 for ; Wed, 03 Apr 2019 15:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=x4AoO57WHK/MYPvuGCmhxuDFGHngHPzzs/C0+HpF0ek=; b=qzW9YPDhImBnm2J9wAGZkubnLme2PNhWIFi7ProtMHONQ8iB60hzkIYQBYO5ps1LDF Lf/MwujgucF7pX+CwQLe0kR7ltWwqtKJReP7KOqKFSSk0PEAflw4DPGXLxjlS2pkchPh zOAZsjM/Tp4FDFibEWmdMqLv5+myEhtUPoAOt+cZK+vZOTuolvIhnVdOMYybqEIVhpMW BzTCmO/Z99dyvOGJRqlD+/PJsNv4D3tNdy/MjCbM0CChBR0c9ZyF9c43WyGun+wKWi+h 2DZCmBnWFdMuzGeQs/eZRtkFx2ecWWyVfvrrdBTaH0nmCMfRBAxCpMa7OurewFS+M9X8 YthQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=x4AoO57WHK/MYPvuGCmhxuDFGHngHPzzs/C0+HpF0ek=; b=Xb6XP0ZWDIDDUTk0WOnwLBpwPq6Pievz7gqcBQItU5sG7CR2DCX/TQ3XeHWupNWZ+r VCtBqYVMjMGPXzCrgqCTEqFut4zuP4vEm/bHaYIUW9xATVoVk2jU4iN143/Ge3mK/2o9 RoxZjOq+huxZp17HTYKhRDmTMGvgxZw+/WtakWt8oi2dlyOQiZeiVLA8Br6bsLXKDbKy hPZqGcZ+3foVHRVZihQeyWMC3iSdFLQ7KR6tRur8tVLw+SLwtcOL4xc4Yy/9RCobLXkw 2rZEAZPhVrvb6es7jpU08w/X5fDmVnAdF3WYgJxvdhGOPFjv9Q+MZhPkyV7JjhhFtEKh +HtA== X-Gm-Message-State: APjAAAXSioWIRC7cIWYkTjbwDM5u94Pe114JiGus2KfOfvI2h+NTlfeh OT1FLSkBRuQqu4adoE8tew== X-Google-Smtp-Source: APXvYqxIH6IQPxwxOV1KMuzM0sAMRUt59n9pnqUWvlVZH/KAsphCzYLKL3lH2AXZNLEu+/zE2MJffA== X-Received: by 2002:a65:6105:: with SMTP id z5mr2209772pgu.378.1554329884029; Wed, 03 Apr 2019 15:18:04 -0700 (PDT) Received: from localhost.localdomain ([114.71.48.5]) by smtp.gmail.com with ESMTPSA id d3sm26056314pfn.113.2019.04.03.15.18.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 15:18:03 -0700 (PDT) From: "Daniel T. Lee" To: Daniel Borkmann , Alexei Starovoitov Cc: netdev@vger.kernel.org Subject: [PATCH v3 1/2] selftests/bpf: ksym_search won't check symbols exists Date: Thu, 4 Apr 2019 07:17:55 +0900 Message-Id: <20190403221756.23095-1-danieltimlee@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently, ksym_search located at trace_helpers won't check symbols are existing or not. In ksym_search, when symbol is not found, it will return &syms[0](_stext). But when the kernel symbols are not loaded, it will return NULL, which is not a desired action. This commit will add verification logic whether symbols are loaded prior to the symbol search. Signed-off-by: Daniel T. Lee --- tools/testing/selftests/bpf/trace_helpers.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c index 4cdb63bf0521..9a9fc6c9b70b 100644 --- a/tools/testing/selftests/bpf/trace_helpers.c +++ b/tools/testing/selftests/bpf/trace_helpers.c @@ -52,6 +52,10 @@ struct ksym *ksym_search(long key) int start = 0, end = sym_cnt; int result; + /* kallsyms not loaded. return NULL */ + if (sym_cnt <= 0) + return NULL; + while (start < end) { size_t mid = start + (end - start) / 2; -- 2.17.1