From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4134C4360F for ; Thu, 4 Apr 2019 17:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99F6E206DD for ; Thu, 4 Apr 2019 17:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728643AbfDDRrV (ORCPT ); Thu, 4 Apr 2019 13:47:21 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48758 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfDDRrV (ORCPT ); Thu, 4 Apr 2019 13:47:21 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BA518146E7722; Thu, 4 Apr 2019 10:47:20 -0700 (PDT) Date: Thu, 04 Apr 2019 10:47:20 -0700 (PDT) Message-Id: <20190404.104720.442549578926482843.davem@davemloft.net> To: dcaratti@redhat.com Cc: mcroce@redhat.com, netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, yotamg@mellanox.com Subject: Re: [PATCH net] net/sched: act_sample: fix divide by zero in the traffic path From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 10:47:21 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Davide Caratti Date: Thu, 4 Apr 2019 12:31:35 +0200 > the control path of 'sample' action does not validate the value of 'rate' > provided by the user, but then it uses it as divisor in the traffic path. > Validate it in tcf_sample_init(), and return -EINVAL with a proper extack > message in case that value is zero, to fix a splat with the script below: ... > Add a TDC selftest to document that 'rate' is now being validated. > > Reported-by: Matteo Croce > Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action") > Signed-off-by: Davide Caratti Applied and queued up for -stable. Thanks for adding a unit test.