From: David Miller <davem@davemloft.net>
To: john.hurley@netronome.com
Cc: jiri@mellanox.com, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, vladbu@mellanox.com,
oss-drivers@netronome.com
Subject: Re: [PATCH net-next 1/1] net: sched: ensure tc flower reoffload takes filter ref
Date: Thu, 04 Apr 2019 17:20:06 -0700 (PDT) [thread overview]
Message-ID: <20190404.172006.2092092064840910481.davem@davemloft.net> (raw)
In-Reply-To: <1554245600-11513-1-git-send-email-john.hurley@netronome.com>
From: John Hurley <john.hurley@netronome.com>
Date: Tue, 2 Apr 2019 23:53:20 +0100
> Recent changes to TC flower remove the requirement for rtnl lock when
> accessing and modifying filters. Refcounts now ensure access and deletion
> do not happen concurrently. However, the reoffload function which cycles
> through all filters and replays them to registered hw drivers is not
> protected.
>
> Use the fl_get_next_filter() function to cycle the filters for reoffload
> and ensure the ref taken by this function is put when done with each
> filter.
>
> Signed-off-by: John Hurley <john.hurley@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied, thank you.
prev parent reply other threads:[~2019-04-05 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 22:53 [PATCH net-next 1/1] net: sched: ensure tc flower reoffload takes filter ref John Hurley
2019-04-03 15:53 ` Vlad Buslov
2019-04-05 0:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404.172006.2092092064840910481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).