From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, liam.mcbirnie@boeing.com,
roopa@cumulusnetworks.com, stephen@networkplumber.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net] net: bridge: always clear mcast matching struct on reports and leaves
Date: Thu, 04 Apr 2019 17:53:26 -0700 (PDT) [thread overview]
Message-ID: <20190404.175326.553696775953316967.davem@davemloft.net> (raw)
In-Reply-To: <20190403202724.9123-1-nikolay@cumulusnetworks.com>
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Wed, 3 Apr 2019 23:27:24 +0300
> We need to be careful and always zero the whole br_ip struct when it is
> used for matching since the rhashtable change. This patch fixes all the
> places which didn't properly clear it which in turn might've caused
> mismatches.
>
> Thanks for the great bug report with reproducing steps and bisection.
...
> Reported-by: liam.mcbirnie@boeing.com
> Fixes: 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Applied and queued up for -stable.
> I will cook a selftest for this as well.
Thanks in advance for this, that's great.
prev parent reply other threads:[~2019-04-05 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 18:53 Fw: [Bug 203137] New: Bridge does not forward multicast if multicast_querier is enabled Stephen Hemminger
2019-04-03 19:57 ` Nikolay Aleksandrov
2019-04-03 20:27 ` [PATCH net] net: bridge: always clear mcast matching struct on reports and leaves Nikolay Aleksandrov
2019-04-05 0:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404.175326.553696775953316967.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=liam.mcbirnie@boeing.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).