From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E79C4360F for ; Fri, 5 Apr 2019 00:55:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 672FD2171F for ; Fri, 5 Apr 2019 00:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729887AbfDEAzw (ORCPT ); Thu, 4 Apr 2019 20:55:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55616 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfDEAzw (ORCPT ); Thu, 4 Apr 2019 20:55:52 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 907031473A486; Thu, 4 Apr 2019 17:55:51 -0700 (PDT) Date: Thu, 04 Apr 2019 17:55:51 -0700 (PDT) Message-Id: <20190404.175551.1772173226988184513.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 0/2] net: phy: use generic PHY ability readers if callback get_features isn't set From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 17:55:51 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Wed, 3 Apr 2019 23:13:18 +0200 > Meanwhile we have generic functions for reading the abilities of > Clause 22 / 45 PHY's. This allows to use them as fallback in case > callback get_features isn't set. Benefit is the reduction of > boilerplate code in PHY drivers. > > v2: > - adjust a comment in patch 1 to match the code Series applied, thanks.