From: David Miller <davem@davemloft.net>
To: lorenzo.bianconi@redhat.com
Cc: netdev@vger.kernel.org, jesse@kernel.org
Subject: Re: [PATCH net] ipv6: sit: reset ip header pointer in ipip6_rcv
Date: Thu, 04 Apr 2019 18:35:18 -0700 (PDT) [thread overview]
Message-ID: <20190404.183518.2166748054843899640.davem@davemloft.net> (raw)
In-Reply-To: <8aaf175761cb492fe484932053d5e4b2f3e0bb89.1554388480.git.lorenzo.bianconi@redhat.com>
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date: Thu, 4 Apr 2019 16:37:53 +0200
> ipip6 tunnels run iptunnel_pull_header on received skbs. This can
> determine the following use-after-free accessing iph pointer since
> the packet will be 'uncloned' running pskb_expand_head if it is a
> cloned gso skb (e.g if the packet has been sent though a veth device)
...
> Fix it resetting iph pointer after iptunnel_pull_header
>
> Fixes: a09a4c8dd1ec ("tunnels: Remove encapsulation offloads on decap")
> Tested-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Good catch, applied, thanks.
next prev parent reply other threads:[~2019-04-05 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1554388480.git.lorenzo.bianconi@redhat.com>
2019-04-04 14:37 ` [PATCH net] ipv6: sit: reset ip header pointer in ipip6_rcv Lorenzo Bianconi
2019-04-05 1:35 ` David Miller [this message]
2019-04-05 10:00 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404.183518.2166748054843899640.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).