netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: "wanghai (M)" <wanghai26@huawei.com>
Cc: syzbot <syzbot+6024817a931b2830bc93@syzkaller.appspotmail.com>,
	alexander.h.duyck@intel.com, amritha.nambiar@intel.com,
	andriy.shevchenko@linux.intel.com, davem@davemloft.net,
	dmitry.torokhov@gmail.com, f.fainelli@gmail.com,
	idosch@mellanox.com, joe@perches.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	stephen@networkplumber.org, syzkaller-bugs@googlegroups.com,
	tyhicks@canonical.com, yuehaibing@huawei.com,
	gregkh@linuxfoundation.org
Subject: Re: kernel BUG at net/core/net-sysfs.c:LINE!
Date: Fri, 5 Apr 2019 03:55:22 +0100	[thread overview]
Message-ID: <20190405025522.GI2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <79eff7ec-4127-e58c-bf11-ade3b482fb43@huawei.com>

On Thu, Apr 04, 2019 at 11:19:03AM +0800, wanghai (M) wrote:
> Can someone fix this issue? Thanks.

Revert the bogus patch, perhaps?  Because bogus it is - failure of
register_netdevice() should NOT drop the reference it's been given.
It's up to the caller and that's when the name will be freed.

      parent reply	other threads:[~2019-04-05  2:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23  7:32 kernel BUG at net/core/net-sysfs.c:LINE! syzbot
2019-03-23 17:16 ` Andy Shevchenko
2019-03-25 15:20   ` wanghai (M)
2019-03-25 16:10     ` Andy Shevchenko
2019-03-25 18:55       ` Dmitry Torokhov
2019-03-25 19:18         ` Dmitry Torokhov
2019-04-04  3:19 ` wanghai (M)
2019-04-04  3:53   ` Eric Dumazet
2019-04-05  2:55   ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405025522.GI2217@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=alexander.h.duyck@intel.com \
    --cc=amritha.nambiar@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=idosch@mellanox.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=syzbot+6024817a931b2830bc93@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tyhicks@canonical.com \
    --cc=wanghai26@huawei.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).