netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Captain Wiggum <captwiggum@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
	Eric Dumazet <edumazet@google.com>,
	Peter Oskolkov <posk@google.com>,
	netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu
Date: Fri, 5 Apr 2019 06:50:47 +0200	[thread overview]
Message-ID: <20190405045047.GB553@kroah.com> (raw)
In-Reply-To: <CAB=W+onFe1LW2K8=2+U58TatrD6U_NqKV+B4G9N6jUo8WkD_hg@mail.gmail.com>

On Thu, Apr 04, 2019 at 06:18:30PM -0600, Captain Wiggum wrote:
> Hi Greg,
> 
> A previous bad patch breaks 18 test cases for IPv6 fragment headers.
> This has already been un-done in upstream, but not in any of the LTS.
> However two upstream patches are first needed to cover a DoS vulnerability.
> 
> For background, there are two mail threads in [netdev] on this subject:
> 1) Subject: TAHI testing fails for IPv6 Fragments in Kernel 4.9 (from
> captwiggum)
> 2) Subject: Please merge IPv6 fix for drop fragment smaller than MTU
> (from captwiggum)
> 
> Two patches from upstream needed first to cover the DoS:
> 
> commit d4289fcc9b16b89619ee1c54f829e05e56de8b9a
> net: IP6 defrag: use rbtrees for IPv6 defrag
> 
> commit 997dd96471641e147cb2c33ad54284000d0f5e35
> net: IP6 defrag: use rbtrees in nf_conntrack_reasm.c
> 
> One undo-patch to fix the IPv6 fragment headers:
> 
> ipv6: defrag: drop non-last frags smaller than min mtu
> UN-DO: commit a8444b1ccb20339774af58e40ad42296074fb484

For what kernel version(s) do these patches need to be applied?

thanks,

greg k-h

  reply	other threads:[~2019-04-05  4:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05  0:18 [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu Captain Wiggum
2019-04-05  4:50 ` Greg Kroah-Hartman [this message]
2019-04-05 16:22   ` Captain Wiggum
2019-04-06 14:15     ` Sasha Levin
2019-04-06 16:34       ` Florian Westphal
2019-04-08 14:49       ` Captain Wiggum
2019-04-08 14:54         ` Eric Dumazet
2019-04-08 15:09           ` Captain Wiggum
2019-04-08 15:51         ` Sasha Levin
2019-04-08 15:59           ` Peter Oskolkov
2019-04-08 16:29             ` Captain Wiggum
2019-04-08 17:13               ` Peter Oskolkov
2019-04-08 23:15                 ` Sasha Levin
2019-04-08 23:38                   ` Peter Oskolkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405045047.GB553@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=captwiggum@gmail.com \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=posk@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).