From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14E7C4360F for ; Fri, 5 Apr 2019 07:00:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B7EC21850 for ; Fri, 5 Apr 2019 07:00:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ditrLvJE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729631AbfDEHAA (ORCPT ); Fri, 5 Apr 2019 03:00:00 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55596 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbfDEHAA (ORCPT ); Fri, 5 Apr 2019 03:00:00 -0400 Received: by mail-wm1-f65.google.com with SMTP id o25so5483112wmf.5 for ; Thu, 04 Apr 2019 23:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g3NWRY7Fpxws2DYO1e7ffZemPW74RZGNviVD+cjSSew=; b=ditrLvJEIbnb3IRii+7UIRQsYbw6CuTn3TWb3cMk9hbtXMLeA71PbnJcq1zE+rTbSr m4PX0i42duBSIeCaXW9vI2gckySBuPI+T6xxy5GSlFA1vSwDxM0j/M2DK7Q6jH5YhA51 BdDsiKqEZQzTvZ3YBM9DiMab4FDYrBYUoZBjl4Vcc41PUnrxA2oI7OyHO70vHVql1gEP wDWaq2lG+vwLTjZ1IdBs1DD59gKwrzQSiTEo6d4BhZFFbBAiIpN60eJ1DuUEMsxEffcq sXY6NvGiQ2CAK7FolXaVW+Ty9O+8Z43GDN7fd+Gkhrt5yvqyTLpxdRdsWCEqIfuK/xX4 NKBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g3NWRY7Fpxws2DYO1e7ffZemPW74RZGNviVD+cjSSew=; b=nj2wJYayirWmFKkMmHRvUZrPTsrcjnJ4mpzHlve4KP7I62ziKlxQ0MmVx+z0R9sCg7 yfUzvblt4Ji10JNqcio4roFP4DZwOKSnt95I6TSD2WdLSbLNCunqI374ZaW6CEm7AMlQ xQx8C1Qi2iMZPdcvzUcFKPPDOU2Ps5vRSAGnYhmSmhKizNYMmdB5iRFgr/l3ogJNc8xB ljfzWM2GRq/AJHgUEec8RUewNXzlywevrkACeNhAhbqRmlPeSTFsfCfrLEvU+w4XD96t PA0Zjd6ARPM8M68lwQTtnLr5qzQKRhSraE+kZjqC3bdBwmr/ZZEc3XMIsaca6bxdt8GU DJnw== X-Gm-Message-State: APjAAAWLjHGaosLC3u+xTh7kTC3xRkIY5otYWA4ACWj8MjY4z5wwCqou hozwMlIxRoY13XQ2o+FdAQKWEvzC364= X-Google-Smtp-Source: APXvYqwJxNuGAh2nUfimxcI/0wUCg9AbJnnmVXOd/c/PA4Nm3reOe1WPJRErl4bJj3wGI1UdoAwCJg== X-Received: by 2002:a1c:b783:: with SMTP id h125mr6334453wmf.119.1554447598875; Thu, 04 Apr 2019 23:59:58 -0700 (PDT) Received: from jimi ([176.230.77.214]) by smtp.gmail.com with ESMTPSA id n11sm31395590wrt.63.2019.04.04.23.59.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Apr 2019 23:59:58 -0700 (PDT) Date: Fri, 5 Apr 2019 09:59:51 +0300 From: Eyal Birger To: Stephen Hemminger Cc: netdev@vger.kernel.org, antony@phenome.org Subject: Re: [PATCH iproute2-next] ip xfrm: support setting/printing XFRMA_IF_ID attribute in states/policies Message-ID: <20190405095758.3dba71df@jimi> In-Reply-To: <20190404101336.518dc275@shemminger-XPS-13-9360> References: <20190404160738.18687-1-eyal.birger@gmail.com> <20190404101336.518dc275@shemminger-XPS-13-9360> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Stephen, On Thu, 4 Apr 2019 10:13:36 -0700 Stephen Hemminger wrote: > On Thu, 4 Apr 2019 19:07:38 +0300 > Eyal Birger wrote: > > > The XFRMA_IF_ID attribute is set in policies/states for them to be > > associated with an XFRM interface (4.19+). > > > > Add support for setting / displaying this attribute. > > > > Note that 0 is a valid value therefore set XFRMA_IF_ID if any value > > was provided in command line. > > > > Tested-by: Antony Antony > > Signed-off-by: Eyal Birger > > --- > > Since this works with existing kernel int should not need to wait for > next. Oh, sorry about that. The patch applies cleanly and works on the iproute2 tree. Should I resubmit? Thanks! Eyal.