From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jesse@kernel.org
Subject: Re: [PATCH net] ipv6: sit: reset ip header pointer in ipip6_rcv
Date: Fri, 5 Apr 2019 12:00:40 +0200 [thread overview]
Message-ID: <20190405100039.GB5472@localhost.localdomain> (raw)
In-Reply-To: <20190404.183518.2166748054843899640.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
> From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Date: Thu, 4 Apr 2019 16:37:53 +0200
>
> > ipip6 tunnels run iptunnel_pull_header on received skbs. This can
> > determine the following use-after-free accessing iph pointer since
> > the packet will be 'uncloned' running pskb_expand_head if it is a
> > cloned gso skb (e.g if the packet has been sent though a veth device)
> ...
> > Fix it resetting iph pointer after iptunnel_pull_header
> >
> > Fixes: a09a4c8dd1ec ("tunnels: Remove encapsulation offloads on decap")
> > Tested-by: Jianlin Shi <jishi@redhat.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>
> Good catch, applied, thanks.
looking at the code it seems there is the same issue for erspan_v{4,6}.
I will post a fix soon.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2019-04-05 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1554388480.git.lorenzo.bianconi@redhat.com>
2019-04-04 14:37 ` [PATCH net] ipv6: sit: reset ip header pointer in ipip6_rcv Lorenzo Bianconi
2019-04-05 1:35 ` David Miller
2019-04-05 10:00 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405100039.GB5472@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=davem@davemloft.net \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).