From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DDAAC282CE for ; Fri, 5 Apr 2019 21:47:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB77820663 for ; Fri, 5 Apr 2019 21:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="iWihpBrd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbfDEVrF (ORCPT ); Fri, 5 Apr 2019 17:47:05 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46913 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbfDEVrF (ORCPT ); Fri, 5 Apr 2019 17:47:05 -0400 Received: by mail-pg1-f195.google.com with SMTP id q1so3715394pgv.13 for ; Fri, 05 Apr 2019 14:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gUKlMBQelD63RUQmJWWiFvrXmBZA9NjE6ySQNb2eqpw=; b=iWihpBrdsYG4LxVdqH/zSy7y9nz183fjFYlpgeRbOY9l8Ktqt4Agt3uD5goVNIAdWf smtC8SeMm8AhYPjBVBQ2LAYpqGP78x70gj/Hr8nPP/IS1Y1fdFUq7mUpicwqvasFOsNt eGyDN570ssj5WbIHCVX497Gxe8khAQo8HrNahxYWF8G9taAgoyeTUpLaZdAFO2mw+7wa ysLeFX8z8ccL+ygXRBhfKO/93lUWPPe8/cT+C1g0MivzEtRwA7OQf5AKT9PfdIJ8oJ9Y 8rsL6UGcAeAOX7tNdmRyDHY7epuS7c4VW5z2TEgmaT6pCLioyzcgOEaDQb7RbZmm7CVM eZzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gUKlMBQelD63RUQmJWWiFvrXmBZA9NjE6ySQNb2eqpw=; b=BHhjqVB+O7614D3sbEd/1E4S7bqTutxOhWvqldTJygVov+p6IBejuZfA/nAe9kgewp CV0WiIoX8zABYqWlCjKs05589kDbhA54UcB51X+dg+bJV56O1Le54EkuoKHHVwWXBOyX Q+mFO81ra9Y1KePdngHsNzPjDImBvwhWRIEEK2PZ/+u/6Efk1V8qs3E0ye9rQM4DlEUP ct790GaM770QvulyTujw831Lm/bh1rAXBw1PQP8YWLj5ZV3GFF2iw7Hnmsf5e8e4Npk+ kFFwySh+AdGpwmsQlkcGHjhAA4wvcAyl0JAGPakd/KIG+5vZ0LD/ri1OUJNOAEywziQZ ikUw== X-Gm-Message-State: APjAAAXlksqIGcc4FB9H+8zBzcxX9hZLIzu0W44GVodPU5pAaHa2TLBP iheO+r8+eKhzuWAIhG9dbi80Bw== X-Google-Smtp-Source: APXvYqyhzsMd7BwXQMeFcFrVIRaInBIJytbsfaWQMmH00nD9NRJeobmGGr8gTM9lnDqj85iTHdNquA== X-Received: by 2002:a63:6f0a:: with SMTP id k10mr14151363pgc.78.1554500824026; Fri, 05 Apr 2019 14:47:04 -0700 (PDT) Received: from shemminger-XPS-13-9360 ([167.220.104.255]) by smtp.gmail.com with ESMTPSA id v19sm31483077pfn.62.2019.04.05.14.47.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Apr 2019 14:47:03 -0700 (PDT) Date: Fri, 5 Apr 2019 14:47:01 -0700 From: Stephen Hemminger To: Si-Wei Liu Cc: mst@redhat.com, sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces Message-ID: <20190405144701.25a6b55b@shemminger-XPS-13-9360> In-Reply-To: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> References: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 3 Apr 2019 00:52:47 -0400 Si-Wei Liu wrote: > > + if (unlikely(dev->flags & IFF_UP)) { > + struct netdev_notifier_change_info change_info = { > + .info.dev = dev, > + }; > + > + call_netdevice_notifiers_info(NETDEV_CHANGE, > + &change_info.info); > + } This notifier is not really necessary, there already is a CHANGENAME that gets sent. NETDEV_CHANGE is used in other cases to mean that the state (flags) have changed.