From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E74C4360F for ; Fri, 5 Apr 2019 14:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C80322175B for ; Fri, 5 Apr 2019 14:54:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="V7HSgYIa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731247AbfDEOyw (ORCPT ); Fri, 5 Apr 2019 10:54:52 -0400 Received: from mail-eopbgr20086.outbound.protection.outlook.com ([40.107.2.86]:54503 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726626AbfDEOyw (ORCPT ); Fri, 5 Apr 2019 10:54:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yd+kTog40GBYBVhP5DsALWDByUcYB/aiGzo2yYwdJmY=; b=V7HSgYIagtDUDU+ux2tNroeI74XiTIzOKboxwzhv75HDv+1TScFDRMiVRs/iM9O8V5ASkYqBMAdFes6NB0SLK9cY6L6Yq9sg8ameWD3fGmX5sNjq0Ac5dG6WJiVuBuB4+XEONCQldvqnSg/UmsFZ2KoN+tsX7E1zMOe1uXoySQ4= Received: from VI1PR05MB6111.eurprd05.prod.outlook.com (20.178.204.213) by VI1PR05MB5325.eurprd05.prod.outlook.com (20.178.8.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Fri, 5 Apr 2019 14:54:48 +0000 Received: from VI1PR05MB6111.eurprd05.prod.outlook.com ([fe80::28c7:8df1:920b:ee0e]) by VI1PR05MB6111.eurprd05.prod.outlook.com ([fe80::28c7:8df1:920b:ee0e%5]) with mapi id 15.20.1771.016; Fri, 5 Apr 2019 14:54:48 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , David Ahern Subject: Re: [PATCH net-next 16/18] ipv4: Flag fib_info with a fib_nh using IPv6 gateway Thread-Topic: [PATCH net-next 16/18] ipv4: Flag fib_info with a fib_nh using IPv6 gateway Thread-Index: AQHU6w7WqIUr2+sNTkKKsmXBb2J7AaYtqOQA Date: Fri, 5 Apr 2019 14:54:47 +0000 Message-ID: <20190405145444.GB20588@splinter> References: <20190404175007.8150-1-dsahern@kernel.org> <20190404175007.8150-17-dsahern@kernel.org> In-Reply-To: <20190404175007.8150-17-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR0202CA0044.eurprd02.prod.outlook.com (2603:10a6:20b:3a::21) To VI1PR05MB6111.eurprd05.prod.outlook.com (2603:10a6:803:eb::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [79.176.7.115] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fb59a01c-e4e6-42e1-72e4-08d6b9d6a5c9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB5325; x-ms-traffictypediagnostic: VI1PR05MB5325: x-microsoft-antispam-prvs: x-forefront-prvs: 0998671D02 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(136003)(366004)(396003)(39860400002)(346002)(376002)(199004)(189003)(33656002)(4326008)(81166006)(53936002)(5660300002)(186003)(54906003)(6486002)(6246003)(26005)(25786009)(106356001)(105586002)(66066001)(102836004)(6916009)(9686003)(6512007)(33716001)(99286004)(2906002)(6506007)(71200400001)(81156014)(3846002)(14454004)(71190400001)(229853002)(8676002)(305945005)(8936002)(1076003)(76176011)(478600001)(386003)(7736002)(486006)(476003)(68736007)(14444005)(256004)(4744005)(316002)(11346002)(86362001)(6436002)(6116002)(446003)(97736004)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5325;H:VI1PR05MB6111.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: bvGES58Zc6b5EuEpA1GRRtykNya/UXigxaMIUAjMV6Byeyg1Fi10HJD4dCCCgnomuX+Eqh0Y6w9Ore8pVjTnz3Ej9uPFHOvHaCWdkJ5hm6lY+qGc2J92PdQRfVL/3kHmJkO8iUJjzKqhmTdwvyICUOYNbQEIyFm1ZgjA3eAQq5USyhWDpzvQcj8uUb9HQzcQktW/85XJPS7Hu86WSqE2u1Gtpkd8TUQdj8tLoWgvJFjXJk8JSZ7AapysI8R92phkG6V8tYvUe6why+hXx/iI5ohrVZeJeoHqo42aJPFEq7KNXbKPqD2qWCSIpCkbG1zFv9PIZ+g8KzoOkPsXERLq7fcKT9eV/R1Evx38WTTkVyCEO+x+/5xcZjlRpcmk22P/+T2ELRLDRV7C6Uo1loXzzty7s7pWVOVz6tja4LknWN0= Content-Type: text/plain; charset="us-ascii" Content-ID: <91946DE07236DB4DAC95CB32735F824F@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb59a01c-e4e6-42e1-72e4-08d6b9d6a5c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2019 14:54:47.8118 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5325 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 04, 2019 at 10:50:05AM -0700, David Ahern wrote: > From: David Ahern >=20 > Until support is added to the offload drivers, they need to be able to > reject routes with an IPv6 gateway. To that end add a flag to fib_info > that indicates if any fib_nh has a v6 gateway. The flag allows the driver= s > to efficiently know the use of a v6 gateway without walking all fib_nh > tied to a fib_info each time a route is added. >=20 > Update mlxsw and rocker to reject the routes with extack message as to wh= y. This looks good. I'll look into adding support in mlxsw.