From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB8BC282CE for ; Fri, 5 Apr 2019 21:17:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA75F2173C for ; Fri, 5 Apr 2019 21:17:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=arroyo.io header.i=@arroyo.io header.b="eb52QxL7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726409AbfDEVRC (ORCPT ); Fri, 5 Apr 2019 17:17:02 -0400 Received: from mail-it1-f175.google.com ([209.85.166.175]:54805 "EHLO mail-it1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfDEVRC (ORCPT ); Fri, 5 Apr 2019 17:17:02 -0400 Received: by mail-it1-f175.google.com with SMTP id a190so11776496ite.4 for ; Fri, 05 Apr 2019 14:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arroyo.io; s=google; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=znLaXPfxRrvvLkTN4SRsNWPSFyMmuaKYjMSaUd/zpXY=; b=eb52QxL7ML4V5qUU2Y4AVUvNcOWznqUXx25ZcT71j7O0UaCCuS0yLO0KK+AKmyuPEK fRDzFeu6gyN5neZOCUsryzepOu/rnDmxcib6gO7wePaufSjAVfTY4taimSEN13e0CA6B N78N9jCSAvMNz1pTUuxSxbNY89lIZMyC5n425+uWZzffT//MPJqTXKOm36v09C8DR/lC C6pRoNVzGUAHQ0gHAhrKXDVThuLwFaPwKkf8ynctLdujHSwxwIw2eY0NAhN3kWeBx8WE p+AKWkuLcTd1ZfX1k1y/SIf1+VmkictPGGG6D28QG7EwJi7dlcsnrPCYEp9++XLol0tE x8Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=znLaXPfxRrvvLkTN4SRsNWPSFyMmuaKYjMSaUd/zpXY=; b=VSX7NRh34v/H25nGVo6/sMj2uJl0BRuvT5ZARRhzP5ZDIg6eugT2KTucDf8x7nqAcy CpfLBF92J6IecnzJNEbHcgjYgJPVi/+T7Eyx2GZBVeLaFoKgvo5b1IhctX8QUZ3KYigz 6K+uUQv5oSDZlpwHjhckg8e8lAh82+K/A64pnHUScDEoTGU53r4GM4YwFxx8nGzwngkx G3cH3SW/2vch8UAjhHmMKuEHNcgEvYkTM/SxFlsy2CTAtoYjbwFcVB+camBT61WEiAdD DIQslCjBOF9cWUoon7OF+osHzfcQsRXICXIR5BRrujbNuszKVb+0PzqcVSTp+70w69cd avsQ== X-Gm-Message-State: APjAAAUW6YWa73214VySy0BLKEw9ANfTRRdD2xsWdZOOdRJrQ/NfiDN5 wGKkByTRJAAHd6F/jcvSOME44/Ppt7Z62gqIucQJyrnt+Q7NZzawuIScpIXV/qNQ8qyxG/5dPrD PxiJszZfOTT6EB0Dd9A== X-Google-Smtp-Source: APXvYqxWBML6H8pkygO4jM16XKazsfjvABkuwZlkK7pp0i3K1LVbLu7arkfeFsWYj9v6mlvZF1b5tQ== X-Received: by 2002:a02:c496:: with SMTP id t22mr12130792jam.53.1554499021310; Fri, 05 Apr 2019 14:17:01 -0700 (PDT) Received: from aquamarine (047-006-040-041.res.spectrum.com. [47.6.40.41]) by smtp.gmail.com with ESMTPSA id o203sm1419498itd.1.2019.04.05.14.17.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 14:17:01 -0700 (PDT) Date: Fri, 5 Apr 2019 17:16:57 -0400 From: Matt Ellison To: Antony Antony Cc: netdev@vger.kernel.org Subject: Re: [iproute2] ip: support for xfrm interfaces Message-ID: <20190405171657.27190bfa@aquamarine> In-Reply-To: <20190405210317.dtvseosbu3tobula@AntonyAntony.local> References: <20190101124001.28e58469@aquamarine> <20190404162522.mnxrw5afya7nghsf@AntonyAntony.local> <20190405154602.7a2aaa69@aquamarine> <20190405210317.dtvseosbu3tobula@AntonyAntony.local> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > One comment. It seems to accept -ve value for if_id and quietly set > to 0 may be throw an error for -ve values? or take it as u32? > in my opinion setting to 0 is confusing Ah good catch. I'll add the check in my version. -- Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.