From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC107C282CE for ; Fri, 5 Apr 2019 22:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85A0320989 for ; Fri, 5 Apr 2019 22:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726494AbfDEWBt (ORCPT ); Fri, 5 Apr 2019 18:01:49 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:44790 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfDEWBs (ORCPT ); Fri, 5 Apr 2019 18:01:48 -0400 Received: by mail-qk1-f194.google.com with SMTP id y5so4755786qkc.11 for ; Fri, 05 Apr 2019 15:01:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UxwR3ByrKxtj4UoqemofLtabZdjmCyljfYH8M//zFIo=; b=dWpzK6aOZfUQocGM8/r53wzaeJgHDEjLuv0QojXl3cTHmHv1QmDKTX8B/4Fjxql/yv yX4NJRiCFRm47wDjAGLh1PDwvgsNIzs7bobAV21qfxsZb1uA6n31j8Mtao6Eg+xqhsF6 K5c0HS96/rm8xMZkjaRZGwJrANvnaDpCYO+kR7Xh2P9vxBt+7zyIBuxZul49l39U9Pbp Meql9dRIJMv50HmBh9XZCRC5may+h8dalUMeT7zxzs1s+61EVuoQILJdUeQSOCIC2SMI 23tfdoK6PzNegkWud3aeuNFIO1o7yOwDW17Kf/HK9yDqeaHHr/2FOqlJ5B2fbkZvukyi 5FOQ== X-Gm-Message-State: APjAAAWXCGlO2/HT1FVo2Dey3vNeCrpsm8DxS6mHT1wcHvajmNacrWH+ AEcKIJ9FeQlsYI+OyTf7TBS2Dw== X-Google-Smtp-Source: APXvYqwynvOMx8R8PFZxT9mOkXUIMZpPSzf2ZVjRCerEjjtI7Id7EV19lJP44Ls3rSxWhLCv2nY15w== X-Received: by 2002:ae9:f308:: with SMTP id p8mr11862007qkg.33.1554501707879; Fri, 05 Apr 2019 15:01:47 -0700 (PDT) Received: from redhat.com (pool-173-76-246-42.bstnma.fios.verizon.net. [173.76.246.42]) by smtp.gmail.com with ESMTPSA id y55sm14888816qtk.13.2019.04.05.15.01.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Apr 2019 15:01:46 -0700 (PDT) Date: Fri, 5 Apr 2019 18:01:43 -0400 From: "Michael S. Tsirkin" To: Stephen Hemminger Cc: Si-Wei Liu , sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces Message-ID: <20190405175429-mutt-send-email-mst@kernel.org> References: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> <20190405144701.25a6b55b@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405144701.25a6b55b@shemminger-XPS-13-9360> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 05, 2019 at 02:47:01PM -0700, Stephen Hemminger wrote: > On Wed, 3 Apr 2019 00:52:47 -0400 > Si-Wei Liu wrote: > > > > > + if (unlikely(dev->flags & IFF_UP)) { > > + struct netdev_notifier_change_info change_info = { > > + .info.dev = dev, > > + }; > > + > > + call_netdevice_notifiers_info(NETDEV_CHANGE, > > + &change_info.info); > > + } > > This notifier is not really necessary, there already is a CHANGENAME > that gets sent. > NETDEV_CHANGE is used in other cases to mean that the state (flags) > have changed. The point is some existing scripts might not expect name change to happen without a status change afterwards (since it was impossible for so long). So this reports a change to make sure scripts do not miss it.