From: Antony Antony <antony@phenome.org>
To: Matt Ellison <matt@arroyo.io>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2] ip: support for xfrm interfaces
Date: Fri, 5 Apr 2019 23:03:18 +0200 [thread overview]
Message-ID: <20190405210317.dtvseosbu3tobula@AntonyAntony.local> (raw)
In-Reply-To: <20190405154602.7a2aaa69@aquamarine>
Tested-by: Antony Antony <antony@phenome.org>
On Fri, Apr 05, 2019 at 03:46:02PM -0400, Matt Ellison wrote:
> I recently submitted v3 of the patch, please take a look there.
great. I am testing v3 now.
One comment. It seems to accept -ve value for if_id and quietly set to 0
may be throw an error for -ve values? or take it as u32?
in my opinion setting to 0 is confusing
sudo ./ip/ip link add ipsec0 type xfrm dev enp0s5 if_id -10
build@d28:~/git/iproute2 (master)$ ./ip/ip -d link show ipsec0
33: ipsec0@enp0s5: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/none 00:1c:42:55:d6:ab brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500
xfrm if_id 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size
65536 gso_max_segs 65535
> > Question: is it easy to add "if_id" to "ip link show" output?
>
> Yes, it should show up under the detailed output for the interface (-d).
great thanks.
sudo ./ip/ip link add ipsec0 type xfrm dev enp0s5 if_id 0xAB
./ip/ip -d link show ipsec0
29: ipsec0@enp0s5: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/none 00:1c:42:55:d6:ab brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500
xfrm if_id 0xab addrgenmode eui64 numtxqueues 1 numrxqueues 1
gso_max_size 65536 gso_max_segs 65535
thanks,
-antony
next prev parent reply other threads:[~2019-04-05 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 15:32 [PATCH iproute2] ip: support for xfrm interfaces Matt Ellison
2019-01-01 6:11 ` Stephen Hemminger
2019-01-01 17:40 ` Matt Ellison
2019-04-04 16:25 ` [iproute2] " Antony Antony
2019-04-05 19:46 ` Matt Ellison
2019-04-05 21:03 ` Antony Antony [this message]
2019-04-05 21:16 ` Matt Ellison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405210317.dtvseosbu3tobula@AntonyAntony.local \
--to=antony@phenome.org \
--cc=matt@arroyo.io \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox