From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: sameo@linux.intel.com, christophe.ricard@gmail.com,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org, surenb@google.com
Subject: Re: [PATCH 1/2 net] NFC: nci: Add some bounds checking in nci_hci_cmd_received()
Date: Sat, 06 Apr 2019 15:04:33 -0700 (PDT) [thread overview]
Message-ID: <20190406.150433.1815979462207649083.davem@davemloft.net> (raw)
In-Reply-To: <20190403071248.GA5758@kadam>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 3 Apr 2019 10:12:48 +0300
> This is similar to commit 674d9de02aa7 ("NFC: Fix possible memory
> corruption when handling SHDLC I-Frame commands").
>
> I'm not totally sure, but I think that commit description may have
> overstated the danger. I was under the impression that this data came
> from the firmware? If you can't trust your networking firmware, then
> you're already in trouble.
>
> Anyway, these days we add bounds checking where ever we can and we call
> it kernel hardening. Better safe than sorry.
>
> Fixes: 11f54f228643 ("NFC: nci: Add HCI over NCI protocol support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
prev parent reply other threads:[~2019-04-06 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 7:12 [PATCH 1/2 net] NFC: nci: Add some bounds checking in nci_hci_cmd_received() Dan Carpenter
2019-04-03 7:13 ` [PATCH 2/2 net] nfc: nci: Potential off by one in ->pipes[] array Dan Carpenter
2019-04-06 22:04 ` David Miller
2019-04-06 22:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406.150433.1815979462207649083.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christophe.ricard@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).