From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=R7oE=SJ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2505BC282DA
	for <netdev@archiver.kernel.org>; Sun,  7 Apr 2019 01:14:31 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id EED972133F
	for <netdev@archiver.kernel.org>; Sun,  7 Apr 2019 01:14:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726415AbfDGBO3 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 6 Apr 2019 21:14:29 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:39584 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726168AbfDGBO3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 6 Apr 2019 21:14:29 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 1AB7814BC08A9;
        Sat,  6 Apr 2019 18:14:29 -0700 (PDT)
Date:   Sat, 06 Apr 2019 18:14:28 -0700 (PDT)
Message-Id: <20190406.181428.1813237479044536410.davem@davemloft.net>
To:     liuhangbin@gmail.com
Cc:     netdev@vger.kernel.org, wangchen@cn.fujitsu.com, sbrivio@redhat.com
Subject: Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative
 overflow
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190404124518.16794-1-liuhangbin@gmail.com>
References: <20190404124518.16794-1-liuhangbin@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 06 Apr 2019 18:14:29 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Hangbin Liu <liuhangbin@gmail.com>
Date: Thu,  4 Apr 2019 20:45:18 +0800

> Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti
> overflow"), we should not decrease promiscuity if it is already 0.
> 
> An example is after adding a team interface to bridge, the team interface
> will enter promisc mode. Then if we add a slave to team0, the slave will
> keep promisc off. If we remove team from bridge, both team0 and slave will
> decrease the promiscuity, which will cause a negative overflow on the slave.
> The team's issue will be fixed in a separate patch.
> 
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

These little hacks are endless.

I would rather see team and bridge and bonding appropriately keep the
promisc count adjusted as need when slaves are added/removed etc.

What is the point of the counter if it doesn't "count" properly?

I'm not applying this.

Because if I apply it, this just encourages more hackish workarounds
for the fundamental problem.