From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: jiri@mellanox.com, netdev@vger.kernel.org, bjb@mojatatu.com,
lucasb@mojatatu.com, kleib@mojatatu.com
Subject: Re: [PATCH net] selftests: add a tc matchall test case
Date: Sun, 07 Apr 2019 19:32:31 -0700 (PDT) [thread overview]
Message-ID: <20190407.193231.154740375748044068.davem@davemloft.net> (raw)
In-Reply-To: <20190405122024.2073-1-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Fri, 5 Apr 2019 14:20:24 +0200
> This is a follow up of the commit 0db6f8befc32 ("net/sched: fix ->get
> helper of the matchall cls").
>
> To test it:
> $ cd tools/testing/selftests/tc-testing
> $ ln -s ../plugin-lib/nsPlugin.py plugins/20-nsPlugin.py
> $ ./tdc.py -n -e 2638
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied, thanks Nicolas.
> I'm not sure to understand the goal of this series:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=45b3a3762721
>
> But after it, tc selftests are not intuitive anymore. When naively running them
> (./tdy.py), all fw filter tests fail. It's hard to understand that the problem
> is that they require the 'nsPlugin' plugin to be enabled (by adding a symlink
> *and* providing the '-n' option to tdc.py).
>
> Brenda, why putting the netns code into a plugin that is disabled by default,
> knowing that this code is mandatory to run the test?
Brenda, please respond.
next prev parent reply other threads:[~2019-04-08 2:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 9:35 [PATCH net] net/sched: fix ->get helper of the matchall cls Nicolas Dichtel
2019-04-01 21:13 ` David Miller
2019-04-05 12:20 ` [PATCH net] selftests: add a tc matchall test case Nicolas Dichtel
2019-04-08 2:32 ` David Miller [this message]
2019-04-08 22:24 ` Lucas Bates
2019-04-08 22:45 ` David Miller
2019-04-09 15:29 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407.193231.154740375748044068.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjb@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kleib@mojatatu.com \
--cc=lucasb@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).