From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=X3pK=SK=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DE605C10F0E
	for <netdev@archiver.kernel.org>; Mon,  8 Apr 2019 02:32:34 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B13C920857
	for <netdev@archiver.kernel.org>; Mon,  8 Apr 2019 02:32:34 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726602AbfDHCcd (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 7 Apr 2019 22:32:33 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:56010 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726495AbfDHCcd (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 7 Apr 2019 22:32:33 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 6150B133FBEE7;
        Sun,  7 Apr 2019 19:32:32 -0700 (PDT)
Date:   Sun, 07 Apr 2019 19:32:31 -0700 (PDT)
Message-Id: <20190407.193231.154740375748044068.davem@davemloft.net>
To:     nicolas.dichtel@6wind.com
Cc:     jiri@mellanox.com, netdev@vger.kernel.org, bjb@mojatatu.com,
        lucasb@mojatatu.com, kleib@mojatatu.com
Subject: Re: [PATCH net] selftests: add a tc matchall test case
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190405122024.2073-1-nicolas.dichtel@6wind.com>
References: <20190401.141309.1277998702086618249.davem@davemloft.net>
        <20190405122024.2073-1-nicolas.dichtel@6wind.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 07 Apr 2019 19:32:32 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Fri,  5 Apr 2019 14:20:24 +0200

> This is a follow up of the commit 0db6f8befc32 ("net/sched: fix ->get
> helper of the matchall cls").
> 
> To test it:
> $ cd tools/testing/selftests/tc-testing
> $ ln -s ../plugin-lib/nsPlugin.py plugins/20-nsPlugin.py
> $ ./tdc.py -n -e 2638
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Applied, thanks Nicolas.

> I'm not sure to understand the goal of this series:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=45b3a3762721
> 
> But after it, tc selftests are not intuitive anymore. When naively running them
> (./tdy.py), all fw filter tests fail. It's hard to understand that the problem
> is that they require the 'nsPlugin' plugin to be enabled (by adding a symlink
> *and* providing the '-n' option to tdc.py).
> 
> Brenda, why putting the netns code into a plugin that is disabled by default,
> knowing that this code is mandatory to run the test?

Brenda, please respond.