From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E84EC282DD for ; Sun, 7 Apr 2019 00:10:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0B302171F for ; Sun, 7 Apr 2019 00:10:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="kXodR83I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbfDGAKu (ORCPT ); Sat, 6 Apr 2019 20:10:50 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:37986 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726372AbfDGAKu (ORCPT ); Sat, 6 Apr 2019 20:10:50 -0400 Received: by mail-qt1-f194.google.com with SMTP id d13so11568075qth.5 for ; Sat, 06 Apr 2019 17:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nAcHuzKOp7Og35xJ9qkPg9RRl0wfwnr6s1xFaxaVBMk=; b=kXodR83I85F2t6TrJ7lK5pPAb96V3ezu7UA6bktNZhLq/xWKFzioOv38hC6xnBFNPj BdJwvdXIcnZJ7PUefFAvoZsPOcmLwDt0o8/uCKAmuWh36/1oBfyyI2Nnp8yAfhd86a6p WHELMN8i4fjqF0lg09a6+Tx4r8Xwpyx7PNd57P9EbxjE9JbLK/cOkM27TgSsRA6JLhpF NhoHkTA10ZYhDR4C48WsN17PIbD5Igk7mjLhzIAxGtQWtWkjwVRli7Ag5M516ELmOqZ8 VjPPhy6uMfNwm0RGLaRSpoWuOSjibZgJvgAxGJ/+tWSQcCKjJ6SNqosuz+Zmskot9BZA OFoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nAcHuzKOp7Og35xJ9qkPg9RRl0wfwnr6s1xFaxaVBMk=; b=rQ2EJWRUKit8PV7JyYsDNSS0ZElqFN9x6JQZgccg1mOuW65V9RxFonCIyR/Qb4Eahn JyD+bCLjD1idnFFQVgIxZqg9yZrEe03J9ctAJuc4OU62bvHsxrQWeJqgj6A1jNNYvZnt QRRHoAV0lhF/YjY1tDNYaYB+uvDA7crN4/GKpPkRfsNDyNN3GqZltaHu34GxD9z5iF/p RFDghDFPfJYoZi0/+8N4PzM8rkmJn35PmZAyQZi6dk7uiX9gFhRQDpKmqd9l6CgJfdQV XCk64z6UWVc7iG05aqXxKHJcNXQH0wxAaiumLQKII0nixs69+Xa3oZJjvHCxvPUz7IG6 MYAg== X-Gm-Message-State: APjAAAW5tTV17TvJHGGFrFS1/JvrymGPLUVJLd6B+t6gnuIPJjpPNNIb 9oNLYScFTlXh2K2LudLZEYVdjg== X-Google-Smtp-Source: APXvYqzXsZh8KCRoI7R2RZs557hK5hF2yV1neb48tC1BvCuuHnU4855yDnQu6Y1TgAr+3zsif8h3NQ== X-Received: by 2002:ac8:2413:: with SMTP id c19mr18040488qtc.348.1554595848871; Sat, 06 Apr 2019 17:10:48 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id k89sm3016349qte.33.2019.04.06.17.10.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Apr 2019 17:10:48 -0700 (PDT) Date: Sat, 6 Apr 2019 20:10:46 -0400 From: Josef Bacik To: Matt Mullins Cc: hall@fb.com, ast@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Josef Bacik , Jens Axboe , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Nicolas Ferre , linux-block@vger.kernel.org, nbd@other.debian.org Subject: Re: [PATCH bpf-next v2 2/5] nbd: trace sending nbd requests Message-ID: <20190407001045.vbmwrzaokqb4ufww@MacBook-Pro-91.local> References: <20190405235506.29236-1-mmullins@fb.com> <20190405235506.29236-3-mmullins@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405235506.29236-3-mmullins@fb.com> User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 05, 2019 at 04:55:03PM -0700, Matt Mullins wrote: > This adds a tracepoint that can both observe the nbd request being sent > to the server, as well as modify that request , e.g., setting a flag in > the request that will cause the server to collect detailed tracing data. > > The struct request * being handled is included to permit correlation > with the block tracepoints. > > Signed-off-by: Matt Mullins > --- > MAINTAINERS | 1 + > drivers/block/nbd.c | 5 ++++ > include/trace/events/nbd.h | 56 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 62 insertions(+) > create mode 100644 include/trace/events/nbd.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index e17ebf70b548..6db583d2b0ea 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10737,6 +10737,7 @@ L: linux-block@vger.kernel.org > L: nbd@other.debian.org > F: Documentation/blockdev/nbd.txt > F: drivers/block/nbd.c > +F: include/trace/events/nbd.h > F: include/uapi/linux/nbd.h > > NETWORK DROP MONITOR > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > index 90ba9f4c03f3..7393d04d255c 100644 > --- a/drivers/block/nbd.c > +++ b/drivers/block/nbd.c > @@ -44,6 +44,9 @@ > #include > #include > > +#define CREATE_TRACE_POINTS > +#include > + > static DEFINE_IDR(nbd_index_idr); > static DEFINE_MUTEX(nbd_index_mutex); > static int nbd_total_devices = 0; > @@ -526,6 +529,8 @@ static int nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd, int index) > handle = nbd_cmd_handle(cmd); > memcpy(request.handle, &handle, sizeof(handle)); > > + trace_nbd_send_request(&request, nbd->index, blk_mq_rq_from_pdu(cmd)); > + Just use the handle, not the pointer. Thanks, Josef