From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A893CC10F0E for ; Sun, 7 Apr 2019 15:41:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6770A20880 for ; Sun, 7 Apr 2019 15:41:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="YAwX7934" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbfDGPl6 (ORCPT ); Sun, 7 Apr 2019 11:41:58 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38704 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbfDGPl5 (ORCPT ); Sun, 7 Apr 2019 11:41:57 -0400 Received: by mail-pl1-f196.google.com with SMTP id f36so1353014plb.5 for ; Sun, 07 Apr 2019 08:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+bF6n/Pry+4pd7Gr7TBZeyqXkv1kmhbdH0Zxp5K6iYk=; b=YAwX7934newgJ+z3ds+heKn1mPApcI00eCDCdcVTsYPgWBK4WStodnN0wBH/w8f+KY eGiR3gV2hDsAQZNUFzDi6uS/duUIUEJYAJDwf1fkRg+lKV3ythyF7DLc66GcB0y3u9Jx fd0rgUwVoUrsa59sffueMaESod0DpQmJT6VxhSE7kYg2zbeg3gU1fXxmZCkQIgphOY68 ItMv6v7P1yHzx8qh2zlUFIbk5psGK/wZD5c+tuJgWr2kAkjG3M/Fix8YpSfoU7Z3TUib W/6SxJxgKSktDwndinhB8mUDCxULPSzONyYroVpG1cKlQQlqm4MRJ6GrT4i1m+4s1AN/ wj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+bF6n/Pry+4pd7Gr7TBZeyqXkv1kmhbdH0Zxp5K6iYk=; b=HrJ9oG+B1wu/JeQkz5dHpO7TDdFF6b5EtZdUpZ7RlGY+rC+CF9IzOCtg1mrFcOMafO bdoUoa4ooRC7FVrukSH/EC8pCSxyX77Bn6xkCK5MtoXXcNw++yWGuU4wFIatIhqdA8lm 65VN1OeXsZaahKg3wUFGBeM8wBJJtlaF9ttOFPGK1DkkY8qRF+OpKVR3k3L42HydIpAr K3SLdjn3cY44+VcECEYiD9Mb3m00e+zaIu/O1xDsx5Ej7B6eH4b7oMlUyiT/Ii0J+7xV sxMvu7VIK7uyib4b0JCRaHJSNiy0vwkDsY+TbJedubU3J4yPADkBd5axOATU2b/Wqtke mZnQ== X-Gm-Message-State: APjAAAWQVvfWgDxxsRar2jncEYl9/fEUsh/2P/l9rAYJKHKh2j0Ju0aj 4VIX/TNRvB2vCgSK2ZS8fLtjLA== X-Google-Smtp-Source: APXvYqz5XM/YmI9LZBP0kKtX+Q8Ot72Hj8U80JD2sEoJzpXTDTRDQIXb4WNoW0HvIp7EPXL3+R3MIw== X-Received: by 2002:a17:902:302:: with SMTP id 2mr2431527pld.232.1554651717029; Sun, 07 Apr 2019 08:41:57 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v20sm34209546pfe.118.2019.04.07.08.41.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Apr 2019 08:41:56 -0700 (PDT) Date: Sun, 7 Apr 2019 08:41:52 -0700 From: Stephen Hemminger To: "Michael S. Tsirkin" Cc: Si-Wei Liu , sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces Message-ID: <20190407084152.392955f9@shemminger-XPS-13-9360> In-Reply-To: <20190405175429-mutt-send-email-mst@kernel.org> References: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> <20190405144701.25a6b55b@shemminger-XPS-13-9360> <20190405175429-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 5 Apr 2019 18:01:43 -0400 "Michael S. Tsirkin" wrote: > > > > This notifier is not really necessary, there already is a CHANGENAME > > that gets sent. > > NETDEV_CHANGE is used in other cases to mean that the state (flags) > > have changed. > > The point is some existing scripts might not expect name > change to happen without a status change afterwards (since it was > impossible for so long). So this reports a change > to make sure scripts do not miss it. I don't think it matters because if device named is changed and it is down (!IFF_UP) then only CHANGENAME is sent. The NETDEV_CHANGE is just noise to an application.