From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9ACAC10F0E for ; Sun, 7 Apr 2019 15:43:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A268920896 for ; Sun, 7 Apr 2019 15:43:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="xrGv8O89" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbfDGPn2 (ORCPT ); Sun, 7 Apr 2019 11:43:28 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44214 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbfDGPn1 (ORCPT ); Sun, 7 Apr 2019 11:43:27 -0400 Received: by mail-pg1-f193.google.com with SMTP id i2so5817145pgj.11 for ; Sun, 07 Apr 2019 08:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s04QtBrPGL69WH3yUXBMg8N/CDqGDH51GcDRXlbIsA8=; b=xrGv8O89zEgNZ6dRIvWabri4O/wi3D7RezNcOcvKnYSMmjqTtqEyarFZMqcOhAjH8M x0kjvzBezeCeH7uQyzBVyx5+NCMSvknK11Qa3sJoqfRpq0ACpsdAjAB041uqaVpY6y8b zXevLUMz+woJtgFAkzUd3U77Qb8mYV+Nej/5cQyDmb/RYMlE9lwVhA2w2cI7PKh5f3nW QvioZE6JpezkXX9KcSqjDVyy0e28qjhTfBY4IWD9FTp85QJLQhISxf4ODJJbW/1BOfo8 OYp5QqxbwbSfIXuSkbCod3F0x6nQVDVoX8XfWaPsg8BnhTRlKYZABbc1GumxP2s/reO3 TLFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s04QtBrPGL69WH3yUXBMg8N/CDqGDH51GcDRXlbIsA8=; b=OVI7rj9PKZPcmM5y0Qv6KFzuT5LsL0XJBIaCiELluoSbvdR2ecwLhe/M+EDHcy2Cy9 WApSDFdI+PUHoTsupByvSiAUgE7Kw4sqIQdS0x1gZHqTwneCjPqTmxrG37V7BhMlcuGH 5Bl4+wiwHeXVlr1SlOQa9WQep9NKUizmOcutkCk1OgFZ9ZemELXMVMVYsE0IFvLuVFpP lSSUywXL70L7BrFgkrGLlA9EWHZepVCmTBx2nDLbR3Cilg2nh+Axx92FoFI41Bnz69am TEQwcpz3DcIhwNSujj2/ZnEz9Tsvf1kBgTQQDBnTgqlOC4gEwHhntb8ZuApku2ARgndT RATw== X-Gm-Message-State: APjAAAVR4X6/GsEIWFBn4/GvdzTLSVfPQlUW1l7J8/1dAR0sXm3PH4kw L5lsZoVfDhKoKlf7WoegQjux4g== X-Google-Smtp-Source: APXvYqxSBprLPGh8Oe9G0aflERO1niTbid7i5s6rmg572CjreLzVyZXiH97Pbxa9KOhMGrNMZABtzQ== X-Received: by 2002:a65:554e:: with SMTP id t14mr12331623pgr.107.1554651807197; Sun, 07 Apr 2019 08:43:27 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s15sm32008996pga.71.2019.04.07.08.43.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Apr 2019 08:43:27 -0700 (PDT) Date: Sun, 7 Apr 2019 08:43:24 -0700 From: Stephen Hemminger To: Hangbin Liu Cc: netdev@vger.kernel.org, Wang Chen , David Miller , Stefano Brivio Subject: Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow Message-ID: <20190407084324.48a081f0@shemminger-XPS-13-9360> In-Reply-To: <20190404124518.16794-1-liuhangbin@gmail.com> References: <20190404124518.16794-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 4 Apr 2019 20:45:18 +0800 Hangbin Liu wrote: > Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti > overflow"), we should not decrease promiscuity if it is already 0. This should never happen. If it is a kernel bug and should be reported like refcnt_t overflow.