From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B115C10F13 for ; Mon, 8 Apr 2019 16:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D50B320880 for ; Mon, 8 Apr 2019 16:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728442AbfDHQ5N (ORCPT ); Mon, 8 Apr 2019 12:57:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36858 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726726AbfDHQ5N (ORCPT ); Mon, 8 Apr 2019 12:57:13 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0B437106FA427; Mon, 8 Apr 2019 09:57:13 -0700 (PDT) Date: Mon, 08 Apr 2019 09:57:10 -0700 (PDT) Message-Id: <20190408.095710.652342565205432754.davem@davemloft.net> To: pabeni@redhat.com Cc: netdev@vger.kernel.org, willemb@google.com, edumazet@google.com Subject: Re: [PATCH net-next] datagram: remove rendundant 'peeked' argument From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Apr 2019 09:57:13 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Paolo Abeni Date: Mon, 8 Apr 2019 10:15:59 +0200 > After commit a297569fe00a ("net/udp: do not touch skb->peeked unless > really needed") the 'peeked' argument of __skb_try_recv_datagram() > and friends is always equal to !!'flags & MSG_PEEK'. > > Since such argument is really a boolean info, and the callers have > already 'flags & MSG_PEEK' handy, we can remove it and clean-up the > code a bit. > > Signed-off-by: Paolo Abeni Applied, thanks Paolo.