From: David Miller <davem@davemloft.net>
To: mzhivich@akamai.com
Cc: siva.kallam@broadcom.com, prashant@broadcom.com,
mchan@broadcom.com, shshaikh@marvell.com, manishc@marvell.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant
Date: Mon, 08 Apr 2019 16:30:56 -0700 (PDT) [thread overview]
Message-ID: <20190408.163056.1390434136281842223.davem@davemloft.net> (raw)
In-Reply-To: <1554734927-15522-1-git-send-email-mzhivich@akamai.com>
From: Michael Zhivich <mzhivich@akamai.com>
Date: Mon, 8 Apr 2019 10:48:44 -0400
> This patch series addresses 2 related issues:
>
> 1. ethtool_validate_speed() triggers a "signed-unsigned comparison"
> warning due to type difference of SPEED_UNKNOWN constant (int)
> and argument to ethtool_validate_speed (__u32).
>
> 2. some drivers use u16 storage for SPEED_UNKNOWN constant,
> resulting in value truncation and thus failure to test against
> SPEED_UNKNOWN correctly.
>
> This revised series addresses several feedback comments:
> - split up the patch in to series
> - do not unnecessarily change drivers that use "int" storage
> for speed values
Series applied.
prev parent reply other threads:[~2019-04-08 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:48 [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant Michael Zhivich
2019-04-08 14:48 ` [PATCH v2 1/3] ethtool: avoid signed-unsigned comparison in ethtool_validate_speed() Michael Zhivich
2019-04-08 14:48 ` [PATCH v2 2/3] broadcom: tg3: fix use of SPEED_UNKNOWN ethtool constant Michael Zhivich
2019-04-08 17:52 ` Andrew Lunn
2019-04-08 14:48 ` [PATCH v2 3/3] qlogic: qlcnic: " Michael Zhivich
2019-04-08 17:53 ` Andrew Lunn
2019-04-08 17:54 ` [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant Andrew Lunn
2019-04-08 18:40 ` Zhivich, Michael
2019-04-08 23:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408.163056.1390434136281842223.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=manishc@marvell.com \
--cc=mchan@broadcom.com \
--cc=mzhivich@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=shshaikh@marvell.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).