From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC64C10F13 for ; Mon, 8 Apr 2019 23:30:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 244E620880 for ; Mon, 8 Apr 2019 23:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbfDHXa6 (ORCPT ); Mon, 8 Apr 2019 19:30:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:42006 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfDHXa5 (ORCPT ); Mon, 8 Apr 2019 19:30:57 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E4BF21456F2A1; Mon, 8 Apr 2019 16:30:56 -0700 (PDT) Date: Mon, 08 Apr 2019 16:30:56 -0700 (PDT) Message-Id: <20190408.163056.1390434136281842223.davem@davemloft.net> To: mzhivich@akamai.com Cc: siva.kallam@broadcom.com, prashant@broadcom.com, mchan@broadcom.com, shshaikh@marvell.com, manishc@marvell.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant From: David Miller In-Reply-To: <1554734927-15522-1-git-send-email-mzhivich@akamai.com> References: <1554734927-15522-1-git-send-email-mzhivich@akamai.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Apr 2019 16:30:57 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Michael Zhivich Date: Mon, 8 Apr 2019 10:48:44 -0400 > This patch series addresses 2 related issues: > > 1. ethtool_validate_speed() triggers a "signed-unsigned comparison" > warning due to type difference of SPEED_UNKNOWN constant (int) > and argument to ethtool_validate_speed (__u32). > > 2. some drivers use u16 storage for SPEED_UNKNOWN constant, > resulting in value truncation and thus failure to test against > SPEED_UNKNOWN correctly. > > This revised series addresses several feedback comments: > - split up the patch in to series > - do not unnecessarily change drivers that use "int" storage > for speed values Series applied.