From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D20FC282DD for ; Mon, 8 Apr 2019 02:38:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E623920B1F for ; Mon, 8 Apr 2019 02:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SPn2RGmu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbfDHCi0 (ORCPT ); Sun, 7 Apr 2019 22:38:26 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42295 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbfDHCiX (ORCPT ); Sun, 7 Apr 2019 22:38:23 -0400 Received: by mail-pl1-f196.google.com with SMTP id cv12so6401645plb.9 for ; Sun, 07 Apr 2019 19:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QOaiSBgUtrP0Nzu2mhtUPDrwnQAuQijJq3uBYzp7jUg=; b=SPn2RGmucLcowteNtPbB6ju3RXN/MQx71KdkgACuJk3jR7eMPgkfm01zbQOCD+5MFU 2UlVd0rbQjpcW/ei1121Zo7igrmYNLRq60x2wGChsb4msnL5EFqLnh9/ONNjLGMi3g9S hKyJ2psOA9yfFo2VDXcj08IJk6tffgh02ymDeGgxGRGIp2BS1LhcIwqQ31lwIjggP8l1 +yxfr3Kk3WwzEmZppK/K2ykCkN4wwlZ7kIXEHdTilSJL98KxPDw7nslXm21jZ3zvJL9q LFBK9pXr+oZfAh+nuPXTRbrYIPyUKabGzxjdvuvquKPQThcAeQ6caXJjFlAqoQuAyD15 BT+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QOaiSBgUtrP0Nzu2mhtUPDrwnQAuQijJq3uBYzp7jUg=; b=RG56I+9ccMyMrt4NuNfgJSnuXh1qvfkFwZUM55XnLyhCUqw6yMts/TxnGHg/NoFuCx +2nOve+aorGxhCtL+V0xZq87HmHgs4lmicOD7HS0qGtMuMilO7dE6ShKwZ97lDB0ZdtY 2SGKvaGA7WjKZj7sdzRlC4EdsXZHdPIX+craAeMKN9z62Zqg1byUwvajOz8TbUzeZ0Cz Ld/1JAvPptoL8GapH27bww/pHCOjTxp8Ny4oSceWStVbDIfR5fTnUQiIzbQzGL4lmGqw PDj+DUOFCr97d4qE8gpomGaud7ZAafejWC5RoaHK+W0XM31U2NQGYzyw+vRYrWtpAbkT V6yw== X-Gm-Message-State: APjAAAUvBmqqoxTK07xBMHL1q8U7+3Zfc5qtyww3eanM0pnPxjaah4qV LnA1vg0dSvSFOlwPG8JCeDk= X-Google-Smtp-Source: APXvYqyzgX1FtBsH1D512UipzE0fo3E21n34ZkbMvGPySLSYBL8njdqr0gmQEEeexM0VTLpdZ5uHNg== X-Received: by 2002:a17:902:2e83:: with SMTP id r3mr27515390plb.153.1554691101990; Sun, 07 Apr 2019 19:38:21 -0700 (PDT) Received: from localhost (c-73-222-71-142.hsd1.ca.comcast.net. [73.222.71.142]) by smtp.gmail.com with ESMTPSA id f63sm42265732pfc.180.2019.04.07.19.38.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Apr 2019 19:38:21 -0700 (PDT) Date: Sun, 7 Apr 2019 19:38:18 -0700 From: Richard Cochran To: Heiner Kallweit Cc: Andrew Lunn , Florian Fainelli , David Miller , Ray Jui , Scott Branden , Kevin Hilman , Heiko Stuebner , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection Message-ID: <20190408023818.lmwxtjcqju7p7i7f@localhost> References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all Famous last words! > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these > features explicitly and rely on phylib feature detection. > > I don't have access to most of these PHY's, therefore I'd appreciate > regression testing. How about testing first, then merging? I suggest breaking this out into individual patches that can be Tested-by. Thanks, Richard