From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40FBC282DD for ; Mon, 8 Apr 2019 07:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB5EF20883 for ; Mon, 8 Apr 2019 07:24:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbfDHHYd (ORCPT ); Mon, 8 Apr 2019 03:24:33 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:33733 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfDHHYd (ORCPT ); Mon, 8 Apr 2019 03:24:33 -0400 X-Originating-IP: 90.88.30.125 Received: from localhost (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: maxime.ripard@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id ABE791C0012; Mon, 8 Apr 2019 07:24:24 +0000 (UTC) Date: Mon, 8 Apr 2019 09:24:24 +0200 From: Maxime Ripard To: megous@megous.com Cc: linux-sunxi@googlegroups.com, Chen-Yu Tsai , Rob Herring , Linus Walleij , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org Subject: Re: [PATCH 04/12] arm64: dts: allwinner: orange-pi-3: Enable HDMI output Message-ID: <20190408072424.ilahvtykat5rnzqw@flea> References: <20190405234514.6183-1-megous@megous.com> <20190405234514.6183-5-megous@megous.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ixdxe6i76c5lk3w5" Content-Disposition: inline In-Reply-To: <20190405234514.6183-5-megous@megous.com> User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --ixdxe6i76c5lk3w5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Apr 06, 2019 at 01:45:06AM +0200, megous@megous.com wrote: > From: Ondrej Jirman > > Orange Pi 3 has a DDC_CEC_EN signal connected to PH2, that enables > the DDC I2C bus. Before EDID can be read, we need to pull PH2 high. > > Signed-off-by: Ondrej Jirman > --- > .../dts/allwinner/sun50i-h6-orangepi-3.dts | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > index 7a2424fcaed7..644946749088 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > @@ -21,6 +21,17 @@ > stdout-path = "serial0:115200n8"; > }; > > + connector { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&hdmi_out_con>; > + }; > + }; > + }; > + > leds { > compatible = "gpio-leds"; > > @@ -36,6 +47,15 @@ > }; > }; > > + reg_ddc: ddc-io { > + compatible = "regulator-fixed"; > + regulator-name = "ddc-io"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + enable-active-high; > + gpio = <&pio 7 2 GPIO_ACTIVE_HIGH>; /* PH2 */ > + }; > + This is indented with spaces and generates checkpatch warnings. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ixdxe6i76c5lk3w5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKr3KAAKCRDj7w1vZxhR xd8qAP9L1Z/GaQ6xEO7jcxI5ikarTT0pfnGm4aYkl3gyH6rk/gD+P1PCDG10ikBF sQ/0AppNqh4NsGlelfDfR073XtTxuAE= =+a3C -----END PGP SIGNATURE----- --ixdxe6i76c5lk3w5--