From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AF0C10F13 for ; Mon, 8 Apr 2019 12:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7150A20883 for ; Mon, 8 Apr 2019 12:52:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l3ANbhfi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbfDHMwc (ORCPT ); Mon, 8 Apr 2019 08:52:32 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44187 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfDHMwb (ORCPT ); Mon, 8 Apr 2019 08:52:31 -0400 Received: by mail-pg1-f194.google.com with SMTP id i2so7276433pgj.11 for ; Mon, 08 Apr 2019 05:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PttYQVApnFe6bixv4vx3JOlwZwoFWq697EDfwQq/c/0=; b=l3ANbhfiRYnnWxW0Q8XE5hv3RiDHOT2PfT/p6YxLjsAJXn8bWPji3OuJ5Q/ht4oLc/ qKo8ERGM+6OD/fmF+1eyPCXATqmOZuonAqy6gTyWhtOgv2eM92AuzBPWm+zJAzDD3ned ECUIZqy2WxWrqdiGi1cBMvvZiotxK98/F3buNfVHbejArsI9D28U0TrvdPVIJyqvDNP7 E5rrMalvNUVZLIBaRPgzriK0H+faqqUkU8S27mA14QkOYiNOpMYnNXSTs5MNabn8ylHb wvRJTFwkYN2P0Hex5knMk5SWMXmfGD99qtzFMGBHSDITmjvAmMPJxjUnjEobXb6hUGR1 L/1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PttYQVApnFe6bixv4vx3JOlwZwoFWq697EDfwQq/c/0=; b=dRSUeK6BNdzC2n8oXftY7lPwGzp8DoxraBj+gI9ZzoHGIUTQwethjYfcgBkJ5jiKjW Cza9BdbAw2GpiieQJWGt3PkE5eI7v4zDp5PJczWPg4O8aCJD6qv42VMWtbGxc4228GrQ WiRa18jCiQto1q3mNlYyOG43AuDipNROffofBSgS+xr9LJPrnCgQfoSqYcRUPZoX8z+K 2P3yIIqYUe5QHxwa1esT1y9uWpR6T2wI2uMm9BaHeI723AKWhJ0YCDEVla1VtrYXntoO 6sby6otd98c9Uc2OMnbaONrV4+7gI2PxGOiRP4c8ef0z4jUim/srfNDjAHwZ6qnFnMdK +3AQ== X-Gm-Message-State: APjAAAVdRpOdHuayPSMprwQ6rQGSf3LnwCTTA7Fmse/NGDOhO8qgHx47 xQaTnZzGcwDruYj4QEYZbw4= X-Google-Smtp-Source: APXvYqxobUE/CNitVMjvisEgcyd/9AtyVTbghUzLmXw1yCE22lQBi0Zjm0Df7Lped+nK1ndUF4vdmw== X-Received: by 2002:a63:6844:: with SMTP id d65mr28662322pgc.393.1554727951382; Mon, 08 Apr 2019 05:52:31 -0700 (PDT) Received: from dhcp-12-139.nay.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id p6sm27988865pfd.122.2019.04.08.05.52.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Apr 2019 05:52:30 -0700 (PDT) Date: Mon, 8 Apr 2019 20:52:21 +0800 From: Hangbin Liu To: Stephen Hemminger Cc: netdev@vger.kernel.org, Wang Chen , David Miller , Stefano Brivio Subject: Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow Message-ID: <20190408125221.GR10051@dhcp-12-139.nay.redhat.com> References: <20190404124518.16794-1-liuhangbin@gmail.com> <20190407084324.48a081f0@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190407084324.48a081f0@shemminger-XPS-13-9360> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Apr 07, 2019 at 08:43:24AM -0700, Stephen Hemminger wrote: > On Thu, 4 Apr 2019 20:45:18 +0800 > Hangbin Liu wrote: > > > Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti > > overflow"), we should not decrease promiscuity if it is already 0. > > This should never happen. If it is a kernel bug and should be reported > like refcnt_t overflow. Hi Stephen, The type of promiscuity and allmulti is 'unsigned int'. That why it happened. Thanks Hangbin