From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Simon Horman <horms+renesas@verge.net.au>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH/RFC net-next] ravb: Avoid unsupported internal delay mode for R-Car E3/D3
Date: Mon, 8 Apr 2019 19:49:03 +0200 [thread overview]
Message-ID: <20190408174903.GD15267@lunn.ch> (raw)
In-Reply-To: <12616e19-9127-39db-4346-be642c87b596@cogentembedded.com>
> > @@ -1979,8 +1985,9 @@ static void ravb_set_delay_mode(struct net_device *ndev)
> > priv->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID)
> > set |= APSR_DM_RDM;
> >
> > - if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
> > - priv->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID)
> > + if ((priv->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
> > + priv->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID) &&
> > + !soc_device_match(ravb_delay_mode_quirk_match))
>
> But don't we need to error out of the probing as we can't set the delay mode
> requested?
Yes, if we can, we should error out. It just depends on if there are
broken DT blobs out there. We recently had a lot of pain from broken
DT blobs using the at803x PHY and getting RGMII modes wrong. In the
long run, it is best to if DT, but i've no idea how many boards are
affected.
Andrew
next prev parent reply other threads:[~2019-04-08 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:29 [PATCH/RFC net-next] ravb: Avoid unsupported internal delay mode for R-Car E3/D3 Simon Horman
2019-04-08 9:01 ` Wolfram Sang
2019-04-08 9:48 ` Simon Horman
2019-04-08 11:12 ` Wolfram Sang
2019-04-08 13:02 ` Simon Horman
2019-04-08 13:40 ` Wolfram Sang
2019-04-08 17:39 ` Sergei Shtylyov
2019-04-08 17:49 ` Andrew Lunn [this message]
2019-04-09 10:45 ` Simon Horman
2019-04-09 15:03 ` Sergei Shtylyov
2019-04-10 9:37 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408174903.GD15267@lunn.ch \
--to=andrew@lunn.ch \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).