From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A19FC282CE for ; Tue, 9 Apr 2019 08:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03A9120880 for ; Tue, 9 Apr 2019 08:26:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbfDII0L convert rfc822-to-8bit (ORCPT ); Tue, 9 Apr 2019 04:26:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48646 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726079AbfDII0K (ORCPT ); Tue, 9 Apr 2019 04:26:10 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B7E33099FC8; Tue, 9 Apr 2019 08:26:10 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 046F026E7A; Tue, 9 Apr 2019 08:26:00 +0000 (UTC) Date: Tue, 9 Apr 2019 10:25:59 +0200 From: Jesper Dangaard Brouer To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: David Miller , netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , Jakub Kicinski , =?UTF-8?B?QmrDtnJuVMO2cGVs?= , brouer@redhat.com Subject: Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device Message-ID: <20190409102559.28cbb37a@carbon> In-Reply-To: <155474315681.24432.16316236828243189182.stgit@alrua-x1> References: <155474315642.24432.6179239576879119104.stgit@alrua-x1> <155474315681.24432.16316236828243189182.stgit@alrua-x1> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 09 Apr 2019 08:26:10 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 08 Apr 2019 19:05:56 +0200 Toke Høiland-Jørgensen wrote: > +void dev_map_put_default_map(struct net *net) > +{ > + mutex_lock(&dev_map_mtx); Looks like a white-space error... > + if (atomic_dec_and_test(&net->xdp.default_map.use_cnt)) { > + __dev_map_release_default_map(&net->xdp.default_map); > + } > + mutex_unlock(&dev_map_mtx); And here again. > +} -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer