From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B46A0C10F11 for ; Thu, 11 Apr 2019 02:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85FEE2075B for ; Thu, 11 Apr 2019 02:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfDKCSt (ORCPT ); Wed, 10 Apr 2019 22:18:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50772 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbfDKCSt (ORCPT ); Wed, 10 Apr 2019 22:18:49 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5EDCC14C7F11C; Wed, 10 Apr 2019 19:18:48 -0700 (PDT) Date: Wed, 10 Apr 2019 19:18:47 -0700 (PDT) Message-Id: <20190410.191847.2188283310706561371.davem@davemloft.net> To: liuhangbin@gmail.com Cc: netdev@vger.kernel.org, sbrivio@redhat.com, jiri@resnulli.us, mleitner@redhat.com Subject: Re: [PATCHv2 net] team: set slave to promisc if team is already in promisc mode From: David Miller In-Reply-To: <20190408084517.14712-1-liuhangbin@gmail.com> References: <20190404124702.17041-1-liuhangbin@gmail.com> <20190408084517.14712-1-liuhangbin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Apr 2019 19:18:48 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hangbin Liu Date: Mon, 8 Apr 2019 16:45:17 +0800 > After adding a team interface to bridge, the team interface will enter > promisc mode. Then if we add a new slave to team0, the slave will keep > promisc off. Fix it by setting slave to promisc on if team master is > already in promisc mode, also do the same for allmulti. > > v2: add promisc and allmulti checking when delete ports > > Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device") > Signed-off-by: Hangbin Liu Applied and queued up for -stable.